ARROW-8237: [Python][Documentation] Minor corrections to python minimal build documentation #6845
Conversation
|
@JacekPliszka can you rebase this on latest master? As now it still includes all changes of Wes' PR, which makes it difficult to see what is actually in the diff |
Sorry, corrected. One commit is putting Ubuntu with docker at the top while changing Fedora to podman and moving to bottem + adding disclaimer 2nd commit is adding more environment variables so it is easier to run/rerun the commands from command line without containers. |
|
It is mostly small corrections to what Wes did so possibly he should review it. |
pitrou
left a comment
There was a problem hiding this comment.
Thank for doing this. Here are some comments and questions.
There was a problem hiding this comment.
From my testing, you need to add a dot (.) at the end. This is the "context" argument, which is mandatory at least here (Ubuntu 18.04).
There was a problem hiding this comment.
This I cannot tell as I am running podman and I do not need .
There was a problem hiding this comment.
Ok, but this seems to conflate two things:
- running a container on a Fedora host
- running a Fedora container
Perhaps the note about podman vs. docker should be relegated to a separate section?
There was a problem hiding this comment.
Good point. I will preare separate section about it.
There was a problem hiding this comment.
Doesn't podman support the -v option to create a volume? Is this why you added the COPY lines to the dockerfile?
There was a problem hiding this comment.
It does but it is privilaged operation so you either need to disable security or configure it properly.
Copying scripts at the end of docker file is simpler.
But this is probably for separate section...
There was a problem hiding this comment.
| docker build -t arrow_ubuntu_minimal -f Dockerfile.ubuntu | |
| docker build -t arrow_ubuntu_minimal -f Dockerfile.ubuntu . |
There was a problem hiding this comment.
(without this change, the docker command fails:
"docker build" requires exactly 1 argument.
See 'docker build --help'.
)
There was a problem hiding this comment.
Added though these lines are originally from Wes
build_venv.sh is modified so when running from command line the common directory for all build-related tasks is used.
|
Thanks all! |
Fedora instructions changed to podman with disclaimer added
venv script modified to use environment variables more allowing user to put all build related files to single directory (before some were in HOME, other in / )