Skip to content

ARROW-8106: [Python] Ensure extension array conversion tests passes with latest pandas #6614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jorisvandenbossche wants to merge 1 commit into from
Closed

ARROW-8106: [Python] Ensure extension array conversion tests passes with latest pandas #6614

jorisvandenbossche wants to merge 1 commit into from

Conversation

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Mar 13, 2020

It's not fixing the underlying issue (ARROW-7857), but at least making sure the test build is green again.

@github-actions
Copy link

github-actions bot commented Mar 13, 2020

https://issues.apache.org/jira/browse/ARROW-8106

@lidavidm lidavidm mentioned this pull request Mar 13, 2020
Closed
wesm
wesm approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Can we try to fix the underlying issue before the 0.17.0 closes?

@wesm wesm closed this in 138ab1e Mar 13, 2020
@jorisvandenbossche jorisvandenbossche deleted the ARROW-8106 branch March 13, 2020 14:56
@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Mar 13, 2020

Can we try to fix the underlying issue before the 0.17.0 closes?

I can try to look at the casting issue next week (https://issues.apache.org/jira/browse/ARROW-7858).
But note this is not actually a "bug" in pyarrow. There was a change in pandas (in Int64Dtype.__from_arrow__ to use a cast), which is fine for pandas use cases, but indirectly caused a failure in our tests relying on the old behaviour of pandas. It's just that fixing casting an extension type to its storage type (ARROW-7858) would fix the way we used pandas' __from_arrow__ (the alternative is writing our own pandas ExtensionDtype for testing purposes instead of using pandas' built-in ones, but I would to not do that if possible)

@nugend nugend mentioned this pull request Mar 16, 2020
Closed
@jorisvandenbossche jorisvandenbossche mentioned this pull request Mar 19, 2020
Closed
kou pushed a commit that referenced this pull request Mar 21, 2020
@jorisvandenbossche @kou
ARROW-7857: [Python] Revert temporary changes to pandas extension arr…
0569da4 
…ay tests

Reverts #6614, now ARROW-7858 (casting extension type based on its storage type) is implemented.

Closes #6664 from jorisvandenbossche/ARROW-7857

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@asfimport asfimport mentioned this pull request Mar 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesm wesm wesm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jorisvandenbossche @wesm