ARROW-7321: [CI][GLib] Disable development mode #5964
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because GLib version is old on Debian 10 and Ubuntu 18.04 LTS. GLib 2.58 or earlier generates a warning when we use C++ compiler. It has been fixed in GLib 2.60. Debian 10 ships GLib 2.58 and Ubuntu 18.04 LTS ships GLib 2.56. This fixes CI failure https://circleci.com/gh/ursa-labs/crossbow/5681 : FAILED: arrow-glib/20f505c@@arrow-glib@sha/file.cpp.o ccache c++ -Iarrow-glib/20f505c@@arrow-glib@sha -Iarrow-glib -I../../arrow/c_glib/arrow-glib -I. -I../../arrow/c_glib/ -I/usr/local/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++11 -g -Werror -DARROW_NO_DEPRECATED_API -fPIC -pthread -MD -MQ 'arrow-glib/20f505c@@arrow-glib@sha/file.cpp.o' -MF 'arrow-glib/20f505c@@arrow-glib@sha/file.cpp.o.d' -o 'arrow-glib/20f505c@@arrow-glib@sha/file.cpp.o' -c ../../arrow/c_glib/arrow-glib/file.cpp In file included from /usr/include/glib-2.0/gobject/gobject.h:24:0, from /usr/include/glib-2.0/gobject/gbinding.h:29, from /usr/include/glib-2.0/glib-object.h:23, from ../../arrow/c_glib/arrow-glib/error.h:22, from ../../arrow/c_glib/arrow-glib/error.hpp:24, from ../../arrow/c_glib/arrow-glib/file.cpp:26: ../../arrow/c_glib/arrow-glib/file.cpp: In function 'GType garrow_file_get_type()': /usr/include/glib-2.0/gobject/gtype.h:219:50: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context] #define G_TYPE_MAKE_FUNDAMENTAL(x) ((GType) ((x) << G_TYPE_FUNDAMENTAL_SHIFT)) ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/glib-2.0/gobject/gtype.h:2015:11: note: in definition of macro '_G_DEFINE_INTERFACE_EXTENDED_BEGIN' if (TYPE_PREREQ) \ ^~~~~~~~~~~ /usr/include/glib-2.0/gobject/gtype.h:1756:47: note: in expansion of macro 'G_DEFINE_INTERFACE_WITH_CODE' #define G_DEFINE_INTERFACE(TN, t_n, T_P) G_DEFINE_INTERFACE_WITH_CODE(TN, t_n, T_P, ;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../arrow/c_glib/arrow-glib/file.cpp:40:1: note: in expansion of macro 'G_DEFINE_INTERFACE' G_DEFINE_INTERFACE(GArrowFile, ^~~~~~~~~~~~~~~~~~ /usr/include/glib-2.0/gobject/gtype.h:178:25: note: in expansion of macro 'G_TYPE_MAKE_FUNDAMENTAL' #define G_TYPE_OBJECT G_TYPE_MAKE_FUNDAMENTAL (20) ^~~~~~~~~~~~~~~~~~~~~~~ ../../arrow/c_glib/arrow-glib/file.cpp:42:20: note: in expansion of macro 'G_TYPE_OBJECT' G_TYPE_OBJECT) ^~~~~~~~~~~~~ cc1plus: all warnings being treated as errors
Member
Author
|
@ursabot crossbow submit test-ubuntu-c-glib |
|
AMD64 Conda Crossbow Submit (#81060) builder has been succeeded. Revision: aa09af5 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-367
|
Member
Author
|
Green. I'll merge this. |
nealrichardson
pushed a commit
to nealrichardson/arrow
that referenced
this pull request
Dec 6, 2019
Because GLib version is old on Debian 10 and Ubuntu 18.04 LTS. GLib 2.58 or earlier generates a warning when we use C++ compiler. It has been fixed in GLib 2.60. Debian 10 ships GLib 2.58 and Ubuntu 18.04 LTS ships GLib 2.56. This fixes CI failure https://circleci.com/gh/ursa-labs/crossbow/5681 : FAILED: arrow-glib/20f505c@@arrow-glib@sha/file.cpp.o ccache c++ -Iarrow-glib/20f505c@@arrow-glib@sha -Iarrow-glib -I../../arrow/c_glib/arrow-glib -I. -I../../arrow/c_glib/ -I/usr/local/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++11 -g -Werror -DARROW_NO_DEPRECATED_API -fPIC -pthread -MD -MQ 'arrow-glib/20f505c@@arrow-glib@sha/file.cpp.o' -MF 'arrow-glib/20f505c@@arrow-glib@sha/file.cpp.o.d' -o 'arrow-glib/20f505c@@arrow-glib@sha/file.cpp.o' -c ../../arrow/c_glib/arrow-glib/file.cpp In file included from /usr/include/glib-2.0/gobject/gobject.h:24:0, from /usr/include/glib-2.0/gobject/gbinding.h:29, from /usr/include/glib-2.0/glib-object.h:23, from ../../arrow/c_glib/arrow-glib/error.h:22, from ../../arrow/c_glib/arrow-glib/error.hpp:24, from ../../arrow/c_glib/arrow-glib/file.cpp:26: ../../arrow/c_glib/arrow-glib/file.cpp: In function 'GType garrow_file_get_type()': /usr/include/glib-2.0/gobject/gtype.h:219:50: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context] #define G_TYPE_MAKE_FUNDAMENTAL(x) ((GType) ((x) << G_TYPE_FUNDAMENTAL_SHIFT)) ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/glib-2.0/gobject/gtype.h:2015:11: note: in definition of macro '_G_DEFINE_INTERFACE_EXTENDED_BEGIN' if (TYPE_PREREQ) \ ^~~~~~~~~~~ /usr/include/glib-2.0/gobject/gtype.h:1756:47: note: in expansion of macro 'G_DEFINE_INTERFACE_WITH_CODE' #define G_DEFINE_INTERFACE(TN, t_n, T_P) G_DEFINE_INTERFACE_WITH_CODE(TN, t_n, T_P, ;) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../arrow/c_glib/arrow-glib/file.cpp:40:1: note: in expansion of macro 'G_DEFINE_INTERFACE' G_DEFINE_INTERFACE(GArrowFile, ^~~~~~~~~~~~~~~~~~ /usr/include/glib-2.0/gobject/gtype.h:178:25: note: in expansion of macro 'G_TYPE_MAKE_FUNDAMENTAL' #define G_TYPE_OBJECT G_TYPE_MAKE_FUNDAMENTAL (20) ^~~~~~~~~~~~~~~~~~~~~~~ ../../arrow/c_glib/arrow-glib/file.cpp:42:20: note: in expansion of macro 'G_TYPE_OBJECT' G_TYPE_OBJECT) ^~~~~~~~~~~~~ cc1plus: all warnings being treated as errors Closes apache#5964 from kou/ci-glib-disable-development-mode and squashes the following commits: aa09af5 <Sutou Kouhei> Disable development mode Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because GLib version is old on Debian 10 and Ubuntu 18.04 LTS.
GLib 2.58 or earlier generates a warning when we use C++ compiler. It
has been fixed in GLib 2.60.
Debian 10 ships GLib 2.58 and Ubuntu 18.04 LTS ships GLib 2.56.
This fixes CI failure https://circleci.com/gh/ursa-labs/crossbow/5681 :