Skip to content

ARROW-6773: [C++] Fix filter kernel when filtering with a boolean Array slice #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nealrichardson wants to merge 3 commits into from
Closed

ARROW-6773: [C++] Fix filter kernel when filtering with a boolean Array slice #5570

nealrichardson wants to merge 3 commits into from

Conversation

@nealrichardson
Copy link
Member

@nealrichardson nealrichardson commented Oct 2, 2019

No description provided.

@nealrichardson nealrichardson requested a review from bkietz October 2, 2019 18:50
@github-actions
Copy link

github-actions bot commented Oct 2, 2019

https://issues.apache.org/jira/browse/ARROW-6733

@nealrichardson
Copy link
Member Author

nealrichardson commented Oct 2, 2019

Travis passing on my fork: https://travis-ci.org/nealrichardson/arrow/builds/592762538

@nealrichardson
Copy link
Member Author

nealrichardson commented Oct 3, 2019

Appveyor failure is something with installing glib? https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/27837139/job/kcgd1nufrsgcjqf0

@bkietz
Copy link
Member

bkietz commented Oct 3, 2019

It does look unrelated. I'll try restarting it to see if it evaporates

@nealrichardson
Copy link
Member Author

nealrichardson commented Oct 3, 2019

I already restarted it (well, requested to restart it, so now it's in the queue again)

@nealrichardson
Copy link
Member Author

nealrichardson commented Oct 3, 2019

Appveyor failed again but this also seems to be failing on master. @kou do you know what's up with https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/27840001/job/tgnp57wisjvhyf9a?

An error occurred while installing glib2 (3.3.7), and Bundler cannot continue.
Make sure that `gem install glib2 -v '3.3.7' --source 'https://rubygems.org/'`
succeeds before bundling.

@kou
Copy link
Member

kou commented Oct 3, 2019

This is not a Apache Arrow problem.
This is a glib2 gem problem. I'll fix it soon. Please ignore this for now.

@kou
Copy link
Member

kou commented Oct 3, 2019

#5572 will solve this.

@kou
Copy link
Member

kou commented Oct 3, 2019

#5572 has been merged.
Rebasing will solve this problem.

@bkietz
Copy link
Member

bkietz commented Oct 3, 2019

In that case I'm merging this

@bkietz bkietz changed the title ARROW-6733: [C++] Fix filter kernel when filtering with a boolean Array slice ARROW-6773: [C++] Fix filter kernel when filtering with a boolean Array slice Oct 3, 2019
@bkietz bkietz closed this in f2e8f85 Oct 3, 2019
kszucs pushed a commit that referenced this pull request Oct 5, 2019
@nealrichardson @kszucs
ARROW-6773: [C++] Fix filter kernel when filtering with a boolean Arr…
99db64c 
…ay slice

Closes #5570 from nealrichardson/fix-filter-slice and squashes the following commits:

3a772fc <Neal Richardson> Lint again
f7e9475 <Neal Richardson> lint
96220d1 <Neal Richardson> Test and fix for bug in filter kernel with a slice

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
This was referenced Oct 3, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkietz bkietz bkietz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nealrichardson @bkietz @kou