Skip to content

ARROW-5990: [Python] add bounds check to RowGroupMetaData.column #4911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crepererum wants to merge 1 commit into from
Closed

ARROW-5990: [Python] add bounds check to RowGroupMetaData.column #4911

crepererum wants to merge 1 commit into from

Conversation

@crepererum
Copy link
Contributor

@crepererum crepererum commented Jul 19, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 19, 2019

Codecov Report

Merging #4911 into master will decrease coverage by 22.27%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4911       +/-   ##
===========================================
- Coverage   87.44%   65.16%   -22.28%     
===========================================
  Files         995      486      -509     
  Lines      140479    64291    -76188     
  Branches     1418        0     -1418     
===========================================
- Hits       122841    41895    -80946     
- Misses      17276    22396     +5120     
+ Partials      362        0      -362
Impacted Files Coverage Δ
python/pyarrow/_parquet.pyx 91.32% <100%> (+0.18%) ⬆️
python/pyarrow/tests/test_parquet.py 96.38% <100%> (+0.01%) ⬆️
cpp/src/arrow/util/memory.h 0% <0%> (-100%) ⬇️
cpp/src/gandiva/date_utils.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/memory.cc 0% <0%> (-100%) ⬇️
cpp/src/arrow/filesystem/util-internal.cc 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/sse-util.h 0% <0%> (-100%) ⬇️
cpp/src/gandiva/decimal_type_util.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/compute/logical_type.h 0% <0%> (-100%) ⬇️
cpp/src/parquet/hasher.h 0% <0%> (-100%) ⬇️
... and 750 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1559f2...b05e734. Read the comment docs.

@emkornfield
Copy link
Contributor

emkornfield commented Jul 20, 2019

+1, LGTM

kszucs pushed a commit that referenced this pull request Jul 22, 2019
@crepererum @kszucs
ARROW-5990: [Python] add bounds check to RowGroupMetaData.column
9ec6b81 
Author: Marco Neumann <marco@crepererum.net>

Closes #4911 from crepererum/ARROW-5990 and squashes the following commits:

b05e734 <Marco Neumann> add bounds check to RowGroupMetaData.column
@asfimport asfimport mentioned this pull request Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crepererum @codecov-io @emkornfield