PARQUET-1468: [C++] Clean up ColumnReader/internal::RecordReader code duplication #4906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This change is refactoring only. Technically Parquet is review-then-commit so I'll wait for @xhochy or someone else to take a look before merging |
Codecov Report
@@ Coverage Diff @@
## master #4906 +/- ##
==========================================
+ Coverage 88.5% 89.06% +0.56%
==========================================
Files 909 717 -192
Lines 115568 100244 -15324
Branches 1418 0 -1418
==========================================
- Hits 102279 89280 -12999
+ Misses 12927 10964 -1963
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
kszucs
pushed a commit
that referenced
this pull request
Jul 22, 2019
… duplication A bunch of business logic had gotten copy-pasted to create parquet/arrow/record_writer.*. This bases ColumnReader/RecordReader off a common private base class and removes other code duplication. I'm going to base explorations in ARROW-3772 on this Closes #4906 from wesm/PARQUET-1468 and squashes the following commits: 5eb664f <Wes McKinney> Finish cleaning, compiles and tests pass 3df7c93 <Wes McKinney> Consolidate internal::RecordReader, ColumnReader files Authored-by: Wes McKinney <wesm+git@apache.org> Signed-off-by: Wes McKinney <wesm+git@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of business logic had gotten copy-pasted to create parquet/arrow/record_writer.*. This bases ColumnReader/RecordReader off a common private base class and removes other code duplication.
I'm going to base explorations in ARROW-3772 on this