ARROW-3032: [C++] Clean up Numpy-related headers #4899
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some unused functions
Member
|
Hmm. We've got numpy_to_arrow.h Let me see if I can simplify this situation |
Member
Author
|
Right. When I looked at them, though, I wasn't convinced how to merge them, as it seems they cater to different topics. |
Member
|
Fair enough. OK, let's leave further simplification as Won't Fix |
wesm
approved these changes
Jul 17, 2019
Member
wesm
left a comment
There was a problem hiding this comment.
+1. Travis build https://travis-ci.org/pitrou/arrow/builds/560041983
kszucs
pushed a commit
that referenced
this pull request
Jul 22, 2019
Remove some unused functions Closes #4899 from pitrou/ARROW-3032-numpy-headers and squashes the following commits: e094f3b <Antoine Pitrou> ARROW-3032: Clean up Numpy-related headers Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Wes McKinney <wesm+git@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some unused functions