ARROW-5968: [Java] Remove duplicate Preconditions check in JDBC adapter #4896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1, LGTM |
Contributor
|
Only failing travis build is R which seems like a downlod issu.e |
kszucs
pushed a commit
that referenced
this pull request
Jul 22, 2019
Related to [ARROW-5968](https://issues.apache.org/jira/browse/ARROW-5968). Some Preconditions check are duplicate in JdbcToArrow#sqlToArrow Author: tianchen <niki.lj@alibaba-inc.com> Closes #4896 from tianchen92/jdbc_adapter and squashes the following commits: 0b507ea <tianchen> remove duplicated check
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Related to [ARROW-5968](https://issues.apache.org/jira/browse/ARROW-5968). Some Preconditions check are duplicate in JdbcToArrow#sqlToArrow Author: tianchen <niki.lj@alibaba-inc.com> Closes apache#4896 from tianchen92/jdbc_adapter and squashes the following commits: 0b507ea <tianchen> remove duplicated check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ARROW-5968.
Some Preconditions check are duplicate in JdbcToArrow#sqlToArrow