ARROW-5964: [C++][Gandiva] Remove overflow check after rounding in BasicDecimal128::FromDouble #4894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pravindra
commented
Jul 17, 2019
- std::round can round down also.
- also, there is a check further down for overflow (2^127-1).
- std::round can round down also. - also, there is a check further down for overflow (2^127-1).
Contributor
Author
pitrou
reviewed
Jul 17, 2019
Member
pitrou
left a comment
There was a problem hiding this comment.
Just one question, otherwise LGTM.
(note: Travis-CI failure is unrelated)
pitrou
approved these changes
Jul 17, 2019
Member
pitrou
left a comment
There was a problem hiding this comment.
+1. Will need to wait for green CI...
Member
|
I updated the PR title to add missing context about what this patch is |
Codecov Report
@@ Coverage Diff @@
## master #4894 +/- ##
==========================================
+ Coverage 87.43% 89.05% +1.61%
==========================================
Files 995 718 -277
Lines 140466 100330 -40136
Branches 1418 0 -1418
==========================================
- Hits 122821 89351 -33470
+ Misses 17283 10979 -6304
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
Contributor
Author
pravindra
pushed a commit
to dremio/arrow
that referenced
this pull request
Jul 18, 2019
…sicDecimal128::FromDouble - std::round can round down also. - also, there is a check further down for overflow (2^127-1). Author: Pindikura Ravindra <ravindra@dremio.com> Closes apache#4894 from pravindra/arrow-5964 and squashes the following commits: 8d6f37a <Pindikura Ravindra> fix tests eaee1ab <Pindikura Ravindra> ARROW-5964: remove overflow check after rounding
kszucs
pushed a commit
that referenced
this pull request
Jul 22, 2019
…sicDecimal128::FromDouble - std::round can round down also. - also, there is a check further down for overflow (2^127-1). Author: Pindikura Ravindra <ravindra@dremio.com> Closes #4894 from pravindra/arrow-5964 and squashes the following commits: 8d6f37a <Pindikura Ravindra> fix tests eaee1ab <Pindikura Ravindra> ARROW-5964: remove overflow check after rounding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.