ARROW-5957: [C++][Gandiva] Implement div function in Gandiva #4887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pprudhvi
added a commit
to dremio/arrow
that referenced
this pull request
Jul 18, 2019
Author: Prudhvi Porandla <prudhvi.porandla@icloud.com> Closes apache#4887 from pprudhvi/div-impl and squashes the following commits: aa02da5 <Prudhvi Porandla> add test for float32; specify namespace of trunc 7ac9090 <Prudhvi Porandla> explicit cast after trunc d6a3d60 <Prudhvi Porandla> lint 014658d <Prudhvi Porandla> div for float, double types 7fcaca8 <Prudhvi Porandla> div for integer types
kszucs
pushed a commit
that referenced
this pull request
Jul 22, 2019
Author: Prudhvi Porandla <prudhvi.porandla@icloud.com> Closes #4887 from pprudhvi/div-impl and squashes the following commits: aa02da5 <Prudhvi Porandla> add test for float32; specify namespace of trunc 7ac9090 <Prudhvi Porandla> explicit cast after trunc d6a3d60 <Prudhvi Porandla> lint 014658d <Prudhvi Porandla> div for float, double types 7fcaca8 <Prudhvi Porandla> div for integer types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.