ARROW-5874: [Python] Fix macOS wheels to depend on system or Homebrew OpenSSL #4823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The produced wheel works for me - in the same environment where the release fails. |
xhochy
approved these changes
Jul 8, 2019
Member
xhochy
left a comment
There was a problem hiding this comment.
+1, LGTM. This also works for me.
wesm
pushed a commit
that referenced
this pull request
Jul 13, 2019
… OpenSSL The wheel build and test build succeeds, just the deployments fails because of removed openssl for testing: https://travis-ci.org/ursa-labs/crossbow/builds/555822505 The currently running build should pass: https://travis-ci.org/ursa-labs/crossbow/builds/555849713 although we have a bunch of warnings `<lib> was built for newer OSX version (10.12) than being linked (10.9)` for the dependencies coming from brew. cc @xhochy Author: Krisztián Szűcs <szucs.krisztian@gmail.com> Closes #4823 from kszucs/osx-wheel-openssl and squashes the following commits: eb45ae4 <Krisztián Szűcs> reinstall openssl ca8d177 <Krisztián Szűcs> ignore deps be4ab0f <Krisztián Szűcs> openssl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wheel build and test build succeeds, just the deployments fails because of removed openssl for testing: https://travis-ci.org/ursa-labs/crossbow/builds/555822505
The currently running build should pass: https://travis-ci.org/ursa-labs/crossbow/builds/555849713
although we have a bunch of warnings
<lib> was built for newer OSX version (10.12) than being linked (10.9)for the dependencies coming from brew.cc @xhochy