Skip to content

ARROW-5866: [C++] Remove duplicate library in cpp/Brewfile #4816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shiro615 wants to merge 1 commit into from
Closed

ARROW-5866: [C++] Remove duplicate library in cpp/Brewfile #4816

shiro615 wants to merge 1 commit into from

Conversation

@shiro615
Copy link
Contributor

@shiro615 shiro615 commented Jul 6, 2019

No description provided.

kou
kou approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
We can merge this when CI is green.

@codecov-io
Copy link

codecov-io commented Jul 6, 2019

Codecov Report

Merging #4816 into master will increase coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4816      +/-   ##
==========================================
+ Coverage   88.51%   89.08%   +0.56%     
==========================================
  Files         911      720     -191     
  Lines      115310   100086   -15224     
  Branches     1418        0    -1418     
==========================================
- Hits       102070    89164   -12906     
+ Misses      12878    10922    -1956     
+ Partials      362        0     -362
Impacted Files Coverage Δ
cpp/src/arrow/io/readahead.cc 95.91% <0%> (-1.03%) ⬇️
go/arrow/ipc/writer.go
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
go/arrow/ipc/file_reader.go
js/src/builder/index.ts
js/src/enum.ts
go/arrow/array/builder.go
js/src/util/fn.ts
js/src/Arrow.node.ts
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c037ee2...1a200d4. Read the comment docs.

@kou kou closed this in e0b84f1 Jul 6, 2019
wesm pushed a commit that referenced this pull request Jul 13, 2019
@shiro615 @wesm
ARROW-5866: [C++] Remove duplicate library in cpp/Brewfile
b3731e7 
Author: Yosuke Shiro <yosuke.shiro615@gmail.com>

Closes #4816 from shiro615/cpp-remove-duplicate-library and squashes the following commits:

1a200d4 <Yosuke Shiro>  Remove duplicate library in cpp/Brewfile
@shiro615 shiro615 deleted the cpp-remove-duplicate-library branch July 24, 2019 10:46
@asfimport asfimport mentioned this pull request Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shiro615 @codecov-io @kou