Skip to content

ARROW-5838: [C++] Delegate OPENSSL_ROOT_DIR to bundled gRPC #4795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kou wants to merge 1 commit into from
Closed

ARROW-5838: [C++] Delegate OPENSSL_ROOT_DIR to bundled gRPC #4795

kou wants to merge 1 commit into from

Conversation

@kou
Copy link
Member

@kou kou commented Jul 3, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 4, 2019 •
edited
Loading

Codecov Report

Merging #4795 into master will increase coverage by 1.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4795      +/-   ##
==========================================
+ Coverage   87.43%   89.09%   +1.65%     
==========================================
  Files         996      719     -277     
  Lines      139708   100066   -39642     
  Branches     1418        0    -1418     
==========================================
- Hits       122157    89150   -33007     
+ Misses      17189    10916    -6273     
+ Partials      362        0     -362
Impacted Files Coverage Δ
go/arrow/ipc/writer.go
js/src/util/fn.ts
go/arrow/memory/memory_avx2_amd64.go
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
rust/datafusion/src/bin/main.rs
go/arrow/ipc/file_reader.go
js/src/builder/index.ts
js/src/enum.ts
go/arrow/array/builder.go
... and 269 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ac3099...6014d45. Read the comment docs.

@tianchen92
Copy link
Contributor

tianchen92 commented Jul 4, 2019

Seems there are something wrong with master branch commits.

@kou
Copy link
Member Author

kou commented Jul 4, 2019 •
edited
Loading

We've rebased master branch for 0.14.0 release: https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide#ReleaseManagementGuide-Rebasingthemasterbranchonlocalreleasebranch
All of our pull requests need to rebase on master.

@kszucs kszucs force-pushed the cpp-macos-grpc-openssl branch from 1aee6d4 to 78ddb2a Compare July 4, 2019 07:36
@kszucs
Copy link
Member

kszucs commented Jul 4, 2019

I'll test it locally.

@kszucs kszucs force-pushed the cpp-macos-grpc-openssl branch from 78ddb2a to 91aa1a6 Compare July 4, 2019 14:19
@kou kou force-pushed the cpp-macos-grpc-openssl branch from 91aa1a6 to 6014d45 Compare July 4, 2019 20:47
@kszucs kszucs closed this in ebb8031 Jul 5, 2019
@kou kou deleted the cpp-macos-grpc-openssl branch July 5, 2019 07:35
wesm pushed a commit that referenced this pull request Jul 13, 2019
@kou @wesm
ARROW-5838: [C++] Delegate OPENSSL_ROOT_DIR to bundled gRPC
e74b9d1 
Author: Sutou Kouhei <kou@clear-code.com>

Closes #4795 from kou/cpp-macos-grpc-openssl and squashes the following commits:

6014d45 <Sutou Kouhei>  Delegate OPENSSL_ROOT_DIR to bundled gRPC
@asfimport asfimport mentioned this pull request Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kszucs kszucs kszucs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kou @codecov-io @tianchen92 @kszucs