Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jul 3, 2019

Domain sockets have a platform-dependent path length limit. The release verification script on OSX tends to set a temporary directory that makes the test exceed this. Rather than hardcoding /tmp or some other directory, we skip the test instead.

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ghost
Copy link
Author

ghost commented Jul 3, 2019

Travis build from my fork: https://travis-ci.com/lihalite/arrow/builds/117836190

Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lihalite!

@kszucs kszucs closed this in 41c737d Jul 4, 2019
wesm pushed a commit that referenced this pull request Jul 13, 2019
…h too long

Domain sockets have a platform-dependent path length limit. The release verification script on OSX tends to set a temporary directory that makes the test exceed this. Rather than hardcoding `/tmp` or some other directory, we skip the test instead.

Author: David Li <li.davidm96@gmail.com>

Closes #4793 from lihalite/arrow-5836 and squashes the following commits:

67eb3b7 <David Li> Skip Flight domain socket test when path too long
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
…h too long

Domain sockets have a platform-dependent path length limit. The release verification script on OSX tends to set a temporary directory that makes the test exceed this. Rather than hardcoding `/tmp` or some other directory, we skip the test instead.

Author: David Li <li.davidm96@gmail.com>

Closes apache#4793 from lihalite/arrow-5836 and squashes the following commits:

67eb3b7 <David Li> Skip Flight domain socket test when path too long
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants