ARROW-5834: [Java] Apply new hash map in DictionaryEncoder #4786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4786 +/- ##
=========================================
+ Coverage 87.41% 89.6% +2.18%
=========================================
Files 996 661 -335
Lines 139489 96300 -43189
Branches 1418 0 -1418
=========================================
- Hits 121938 86291 -35647
+ Misses 17189 10009 -7180
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
Contributor
|
LGTM, @tianchen92 can you rebase, i think CI failures should go away. |
Contributor
Author
I just rebased yesterday, should I rebase again or just reopen this PR？ |
Contributor
|
+1 LGTM, CI failure is due to rust (unrelated) |
kszucs
pushed a commit
that referenced
this pull request
Jul 22, 2019
Related to [ARROW-5834](https://issues.apache.org/jira/browse/ARROW-5834). Apply new hash map in DictionaryEncoder to make it work. Meanwhile provide benchmark for DictionaryEncoder: DictionaryEncoderBenchmarks#testEncode: Before: 5 430860.989 ± 14157.675 ns/op After: 5 415703.943 ± 9258.049 ns/op Author: tianchen <niki.lj@alibaba-inc.com> Closes #4786 from tianchen92/ARROW-5834 and squashes the following commits: dce8b6a <tianchen> fix 43f7695 <tianchen> Apply new hash map in DictionaryEncoder
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Related to [ARROW-5834](https://issues.apache.org/jira/browse/ARROW-5834). Apply new hash map in DictionaryEncoder to make it work. Meanwhile provide benchmark for DictionaryEncoder: DictionaryEncoderBenchmarks#testEncode: Before: 5 430860.989 ± 14157.675 ns/op After: 5 415703.943 ± 9258.049 ns/op Author: tianchen <niki.lj@alibaba-inc.com> Closes apache#4786 from tianchen92/ARROW-5834 and squashes the following commits: dce8b6a <tianchen> fix 43f7695 <tianchen> Apply new hash map in DictionaryEncoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ARROW-5834.
Apply new hash map in DictionaryEncoder to make it work.
Meanwhile provide benchmark for DictionaryEncoder:
DictionaryEncoderBenchmarks#testEncode:
Before: 5 430860.989 ± 14157.675 ns/op
After: 5 415703.943 ± 9258.049 ns/op