Skip to content

ARROW-5828: [C++] Add required Protocol Buffers versions check #4785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kou wants to merge 1 commit into from
Closed

ARROW-5828: [C++] Add required Protocol Buffers versions check #4785

kou wants to merge 1 commit into from

Conversation

@kou
Copy link
Member

@kou kou commented Jul 3, 2019

This works Protobuf_SOURCE=AUTO well on environments that have old
Protocol Buffers.

@codecov-io
Copy link

codecov-io commented Jul 3, 2019 •
edited
Loading

Codecov Report

Merging #4785 into master will increase coverage by 1.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4785      +/-   ##
==========================================
+ Coverage   87.43%   89.08%   +1.64%     
==========================================
  Files         996      719     -277     
  Lines      139708   100066   -39642     
  Branches     1418        0    -1418     
==========================================
- Hits       122157    89145   -33012     
+ Misses      17189    10921    -6268     
+ Partials      362        0     -362
Impacted Files Coverage Δ
go/arrow/ipc/writer.go
js/src/util/fn.ts
go/arrow/memory/memory_avx2_amd64.go
rust/datafusion/src/execution/filter.rs
rust/arrow/src/csv/writer.rs
rust/datafusion/src/bin/main.rs
go/arrow/ipc/file_reader.go
js/src/builder/index.ts
js/src/enum.ts
go/arrow/array/builder.go
... and 268 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ac3099...b4e9a88. Read the comment docs.

@kszucs kszucs force-pushed the cpp-protobuf-version-check branch 2 times, most recently from 20405d8 to 3ac1db1 Compare July 4, 2019 14:13
kszucs
kszucs reviewed Jul 4, 2019
View reviewed changes
@kou
[C++] Add required Protocol Buffers versions check
b4e9a88 
This works Protobuf_SOURCE=AUTO well on environments that have old
Protocol Buffers.
@kou kou force-pushed the cpp-protobuf-version-check branch from 3ac1db1 to b4e9a88 Compare July 4, 2019 20:48
kszucs
kszucs approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kszucs kszucs closed this in ad2539d Jul 5, 2019
@kou kou deleted the cpp-protobuf-version-check branch July 5, 2019 07:35
wesm pushed a commit that referenced this pull request Jul 13, 2019
@kou @wesm
ARROW-5828: [C++] Add required Protocol Buffers versions check
071dd29 
This works Protobuf_SOURCE=AUTO well on environments that have old
Protocol Buffers.

Author: Sutou Kouhei <kou@clear-code.com>

Closes #4785 from kou/cpp-protobuf-version-check and squashes the following commits:

b4e9a88 <Sutou Kouhei>  Add required Protocol Buffers versions check
@asfimport asfimport mentioned this pull request Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kszucs kszucs kszucs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kou @codecov-io @kszucs