ARROW-5827: [C++] Require c-ares CMake config #4783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8e255d to
4d3b6e2
Compare
4d3b6e2 to
4b4c7a3
Compare
Codecov Report
@@ Coverage Diff @@
## master #4783 +/- ##
===========================================
+ Coverage 72.26% 89.08% +16.81%
===========================================
Files 822 720 -102
Lines 107713 100086 -7627
Branches 1418 0 -1418
===========================================
+ Hits 77844 89157 +11313
+ Misses 29507 10929 -18578
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
Because gRPC requires c-ares CMake config. See also: https://lists.apache.org/thread.html/babb7985a8206807dd8893a2c7affdb733f3d561ecfcc7f26ba660d9@%3Cdev.arrow.apache.org%3E
4b4c7a3 to
7fe2784
Compare
bkietz
reviewed
Jul 8, 2019
| find_package(c-ares QUIET) | ||
| find_package(c-ares QUIET CONFIG) | ||
| if(NOT c-ares_FOUND) | ||
| # Fedora doesn't package the CMake config |
Member
There was a problem hiding this comment.
Does this mean building anything which requires gRPC on Fedora will fail?
Member
There was a problem hiding this comment.
No -- it means that the system package cannot be used to build gRPC from source. So if -DgRPC_SOURCE=BUNDLED and the system c-ares is found, then gRPC will fail to build
wesm
pushed a commit
that referenced
this pull request
Jul 13, 2019
Because gRPC requires c-ares CMake config. See also: https://lists.apache.org/thread.html/babb7985a8206807dd8893a2c7affdb733f3d561ecfcc7f26ba660d9@%3Cdev.arrow.apache.org%3E Author: Sutou Kouhei <kou@clear-code.com> Closes #4783 from kou/cpp-c-ares-require-cmake-config and squashes the following commits: 7fe2784 <Sutou Kouhei> Require c-ares CMake config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because gRPC requires c-ares CMake config.
See also: https://lists.apache.org/thread.html/babb7985a8206807dd8893a2c7affdb733f3d561ecfcc7f26ba660d9@%3Cdev.arrow.apache.org%3E