ARROW-5791: [C++] Fix infinite loop with more the 32768 columns. #4762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4762 +/- ##
==========================================
+ Coverage 88.39% 88.95% +0.56%
==========================================
Files 908 717 -191
Lines 114157 98953 -15204
Branches 1418 0 -1418
==========================================
- Hits 100904 88021 -12883
+ Misses 12891 10932 -1959
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
Member
|
Thanks for tracking this down! Interesting that it's just a magic number and not an overflow. This LGTM, but I guess someone else should take a look. |
Contributor
Author
|
actually, I should remove code duplication. I also think maybe I allowed for too many columns. |
Contributor
Author
|
Just in case its useful run from travis on my branch: https://travis-ci.org/emkornfield/arrow/builds/552739714 |
Contributor
Author
|
@ursabot build |
kou
pushed a commit
that referenced
this pull request
Jul 4, 2019
But really 32768 columns should be enough for anyone :) Author: Micah Kornfield <emkornfield@gmail.com> Closes #4762 from emkornfield/csv and squashes the following commits: ab0504c <Micah Kornfield> lower number of columns in test to satisfy ming 8f53a8a <Micah Kornfield> remove test acfe2d8 <Micah Kornfield> remove cap, make min rows_in_chunk 512 08ddc22 <Micah Kornfield> remove floor duplication 211472a <Micah Kornfield> powers of 2 are better b91a9e1 <Micah Kornfield> ARROW-5791: Fix infinite loop with more the 32768 columns. Cap max columns
wesm
pushed a commit
that referenced
this pull request
Jul 13, 2019
But really 32768 columns should be enough for anyone :) Author: Micah Kornfield <emkornfield@gmail.com> Closes #4762 from emkornfield/csv and squashes the following commits: ab0504c <Micah Kornfield> lower number of columns in test to satisfy ming 8f53a8a <Micah Kornfield> remove test acfe2d8 <Micah Kornfield> remove cap, make min rows_in_chunk 512 08ddc22 <Micah Kornfield> remove floor duplication 211472a <Micah Kornfield> powers of 2 are better b91a9e1 <Micah Kornfield> ARROW-5791: Fix infinite loop with more the 32768 columns. Cap max columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But really 32768 columns should be enough for anyone :)