ARROW-5785: [Rust] Make the datafusion cli dependencies optional #4742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependent crates may not want the rustyline dependency, specially since the nightly support seems to be custom. Introduce a "cli" feature to allow consumers to not bring in the cli depedencies.
Contributor
|
Thank you for the contribution. Can you open a JIRA and update the PR title? |
Author
|
Added a jira issue, thanks for the pointers :) |
sunchao
approved these changes
Jun 29, 2019
Member
|
Merged. Thanks @winding-lines ! |
Author
|
Chao, are there plans to publish to crates.io arrow and datafusion 0.14.0?
Many thanks!
Marius
…On Fri, Jun 28, 2019 at 8:09 PM Chao Sun ***@***.***> wrote:
Merged. Thanks @winding-lines <https://github.com/winding-lines> !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4742?email_source=notifications&email_token=AAAJYPVXM2OEL7UPZESELPLP43G7XA5CNFSM4H4IZFHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY3QFXQ#issuecomment-506921694>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAJYPUW673AG7NQMABEGMLP43G7XANCNFSM4H4IZFHA>
.
|
Member
|
Seems not from the 0.14.0 RC0 source tarball. @kou : wonder if this (and a few other recently committed Rust changes) can be included in RC1 if there's one? |
Member
|
Yes. |
Member
|
Sure. I'll take a look tonight (PST). |
Member
|
FWIW I ran the Rust verification and it looked okay. |
kou
pushed a commit
that referenced
this pull request
Jul 4, 2019
Dependent crates may not want the rustyline dependency, specially since the nightly support seems to be custom. Introduce a "cli" feature to allow consumers to not bring in the cli depedencies. Author: Marius Seritan <github@winding-lines.com> Closes #4742 from winding-lines/master and squashes the following commits: 2331587 <Marius Seritan> Make the datafusion cli optional Dependent crates may not want the rustyline dependency, specially since the nightly support seems to be custom. Introduce a "cli" feature to allow consumers to not bring in the cli depedencies.
wesm
pushed a commit
that referenced
this pull request
Jul 13, 2019
Dependent crates may not want the rustyline dependency, specially since the nightly support seems to be custom. Introduce a "cli" feature to allow consumers to not bring in the cli depedencies. Author: Marius Seritan <github@winding-lines.com> Closes #4742 from winding-lines/master and squashes the following commits: 2331587 <Marius Seritan> Make the datafusion cli optional Dependent crates may not want the rustyline dependency, specially since the nightly support seems to be custom. Introduce a "cli" feature to allow consumers to not bring in the cli depedencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent crates may not want the rustyline dependency, specially since
the nightly support seems to be custom. Introduce a "cli" feature to
allow consumers to not bring in the cli depedencies.