GH-46481: [C++][Python] Allow nullable schema in FlightInfo#46489
Merged
lidavidm merged 1 commit intoapache:mainfrom May 19, 2025
Merged
GH-46481: [C++][Python] Allow nullable schema in FlightInfo#46489lidavidm merged 1 commit intoapache:mainfrom
lidavidm merged 1 commit intoapache:mainfrom
Conversation
raulcd
approved these changes
May 19, 2025
Member
raulcd
left a comment
There was a problem hiding this comment.
The change LGTM. I am re-running some of the CI failures but they seem unrelated to me.
Member
|
CI failures have been fixed on re-run, the only failure is a known issue. |
This was referenced May 19, 2025
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c47f605. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 509 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The underlying Protobuf field is always nullable and other implementations allow this.
What changes are included in this PR?
Allow empty/nonpresent schema in FlightInfo
Are these changes tested?
Yes
Are there any user-facing changes?
Yes, the getter may now be None. (Previously, this would instead crash, so I believe this is not a breaking change.)
Closes #37677.
Closes #46481.
FlightInfosegfaults when schema is None #46481