GH-45073: [C++][Parquet] Fix generation of repetition levels for encryption test data#45074
Merged
pitrou merged 2 commits intoapache:mainfrom Jan 6, 2025
Merged
Conversation
Contributor
Author
|
The tests will fail until the test data is first fixed in apache/parquet-testing#65 and the submodule updated here. |
b326a78 to
dbde2b0
Compare
Contributor
Author
|
The integration build error looks like #45128, the error message is different but is the same as the current failure on the main branch: |
dbde2b0 to
17dd3c2
Compare
pitrou
approved these changes
Jan 6, 2025
Member
pitrou
left a comment
There was a problem hiding this comment.
+1, thanks for this @adamreeve
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a931aff. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zeroshade
added a commit
to apache/arrow-go
that referenced
this pull request
Mar 12, 2025
As a result of apache/arrow#45073, the test files in the parquet-testing repo were updated (apache/parquet-testing#65). This led to having to also update the corresponding tests here too similar to apache/arrow#45074
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This makes the test data readable by other Parquet implementations that validate the repetition levels.
What changes are included in this PR?
Are these changes tested?
Yes, covered by existing tests.
Are there any user-facing changes?
No