GH-45053: [C++] Add support for Boost 1.87.0 #45057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Dec 26, 2024
### Rationale for this change Boost 1.87.0 removed `BOOST_PROCESS_V2_ASIO_NAMESPACE`: boostorg/process@e827d14 ### What changes are included in this PR? Use `BOOST_PROCESS_V2_NAMESPACE::net` instead. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45053 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Jan 2, 2025
### Rationale for this change Boost 1.87.0 removed `BOOST_PROCESS_V2_ASIO_NAMESPACE`: boostorg/process@e827d14 ### What changes are included in this PR? Use `BOOST_PROCESS_V2_NAMESPACE::net` instead. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#45053 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
13 tasks
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5ec8b64. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 27 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Boost 1.87.0 removed
BOOST_PROCESS_V2_ASIO_NAMESPACE:boostorg/process@e827d14
What changes are included in this PR?
Use
BOOST_PROCESS_V2_NAMESPACE::netinstead.Are these changes tested?
Yes.
Are there any user-facing changes?
No.