GH-40216: [Python][CI][Packaging] Upload nightly wheels to main label of scientific-python-nightly-wheels channel #43932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… label of scientific-python-nightly-wheels channel
raulcd
approved these changes
Sep 3, 2024
Member
raulcd
left a comment
There was a problem hiding this comment.
Thanks! LGTM, I thought we might have wanted to mark them explicitly as dev but if that interferes with downloading from the index, this chaneg sounds good to me
Member
Author
|
@github-actions crossbow submit -g wheel |
|
Revision: d17f84e Submitted crossbow builds: ursacomputing/crossbow @ actions-9d522e96f2
|
pitrou
reviewed
Sep 3, 2024
| {% endmacro %} | ||
|
|
||
| {%- macro github_upload_wheel_scientific_python(pattern) -%} | ||
| {%- if arrow.is_default_branch() -%} |
Member
There was a problem hiding this comment.
I suppose you'll restore this condition before merging the PR?
Member
Author
There was a problem hiding this comment.
For sure! That's just to be able to test this here on the PR (I could maybe also just have merged it without testing, though)
Member
Author
There was a problem hiding this comment.
Reverted the temp commit
Member
|
Some of the uploads to anaconda have failed but this seems more like a connection issues. I will retry some of those jobs: |
This reverts commit d17f84e.
Member
Author
|
Now it is all green, so let's assume it was indeed a temporary connection issue |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 170c599. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
khwilson
pushed a commit
to khwilson/arrow
that referenced
this pull request
Sep 14, 2024
… label of scientific-python-nightly-wheels channel (apache#43932) ### Rationale for this change Small follow-up on apache#43862, correcting the `label` being used to upload the wheels. See apache#40216 (comment) for context. * GitHub Issue: apache#40216 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Small follow-up on #43862, correcting the
labelbeing used to upload the wheels. See #40216 (comment) for context.