GH-43665: [R] Remove references to bindings vignette#43889
Merged
nealrichardson merged 1 commit intoapache:mainfrom Sep 1, 2024
Merged
GH-43665: [R] Remove references to bindings vignette#43889nealrichardson merged 1 commit intoapache:mainfrom
nealrichardson merged 1 commit intoapache:mainfrom
Conversation
|
|
thisisnic
approved these changes
Sep 1, 2024
Member
thisisnic
left a comment
There was a problem hiding this comment.
Thanks for catching these ones!
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1ecfb31. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them. |
khwilson
pushed a commit
to khwilson/arrow
that referenced
this pull request
Sep 14, 2024
) ### Rationale for this change The writing-bindings vignette was removed in apache#41576 (comment). It turns out there were more references to it throughout the docs that I failed to remove ### What changes are included in this PR? Deleting x-refs that don't exist anymore. ### Are these changes tested? Not really ### Are there any user-facing changes? The docs won't point you at links that 404. * GitHub Issue: apache#43665
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The writing-bindings vignette was removed in #41576 (comment). It turns out there were more references to it throughout the docs that I failed to remove
What changes are included in this PR?
Deleting x-refs that don't exist anymore.
Are these changes tested?
Not really
Are there any user-facing changes?
The docs won't point you at links that 404.