GH-38183: [CI][Python] Use pipx to install GCS testbench #43852
Conversation
|
|
|
@github-actions crossbow submit -g cpp |
|
@github-actions crossbow submit -g python -g wheel |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit wheel-windows-cp310-amd64 |
This comment was marked as outdated.
This comment was marked as outdated.
4d3e1cb to
119363c
Compare
|
@github-actions crossbow submit wheel-windows-cp310-amd64 wheel-windows-cp313-amd64 |
|
@github-actions crossbow submit -g python -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit wheel-windows* |
|
Revision: 1da4ed8 Submitted crossbow builds: ursacomputing/crossbow @ actions-7287ca77dd
|
|
@github-actions crossbow submit wheel-windows* |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit wheel-windows* |
|
Revision: 55ece7b Submitted crossbow builds: ursacomputing/crossbow @ actions-4c656a1090
|
|
@github-actions crossbow submit -g python -g cpp |
|
@kou Could you take a look at this PR? |
|
Revision: 55ece7b Submitted crossbow builds: ursacomputing/crossbow @ actions-2df46cee67
|
|
|
||
| # This script is run with PYTHON undefined in some places, | ||
| # but those only use older pythons. | ||
| if [[ -z "${PYTHON_VERSION}" ]] || [[ "${PYTHON_VERSION}" != "3.13" ]]; then |
There was a problem hiding this comment.
This if check could be removed now? (AFAIK we only added it because we couldn't install grpcio on python 3.13, but now this is using pipx (with fixed python version) it shouldn't matter there are no python 3.13 wheels yet?
There was a problem hiding this comment.
Yes, I should open a followup issue.
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 58415d1. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 135 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…e#43852) ### Rationale for this change Installing the GCS testbench using the same Python that's being used to test PyArrow is fragile: some testbench versions may not be compatible, or there could be conflicts among the dependencies of the respective libraries. ### What changes are included in this PR? Use `pipx` to install the GCS testbench in a separate, controlled environment, using an appropriate Python version. ### Are these changes tested? Yes, by CI. ### Are there any user-facing changes? No. * GitHub Issue: apache#38183 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
Installing the GCS testbench using the same Python that's being used to test PyArrow is fragile: some testbench versions may not be compatible, or there could be conflicts among the dependencies of the respective libraries.
What changes are included in this PR?
Use
pipxto install the GCS testbench in a separate, controlled environment, using an appropriate Python version.Are these changes tested?
Yes, by CI.
Are there any user-facing changes?
No.