Skip to content

GH-41748: [Python][Parquet] Update BYTE_STREAM_SPLIT description in write_table() docstring#41759

Merged
jorisvandenbossche merged 1 commit intoapache:mainfrom
pitrou:gh41748-byte-stream-split-docstring
May 22, 2024
Merged

GH-41748: [Python][Parquet] Update BYTE_STREAM_SPLIT description in write_table() docstring#41759
jorisvandenbossche merged 1 commit intoapache:mainfrom
pitrou:gh41748-byte-stream-split-docstring

Conversation

@pitrou
Copy link
Copy Markdown
Member

@pitrou pitrou commented May 21, 2024

Rationale for this change

In PR #40094 (issue GH-39978), we forgot to update the write_table docstring with an accurate description of the supported data types for BYTE_STREAM_SPLIT.

Are these changes tested?

No (only a doc change).

Are there any user-facing changes?

No.

@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #41748 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 21, 2024
Copy link
Copy Markdown
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 065a6da.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 19 possible false positives for unstable benchmarks that are known to sometimes produce them.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…n in write_table() docstring (apache#41759)

### Rationale for this change

In PR apache#40094 (issue apacheGH-39978), we forgot to update the `write_table` docstring with an accurate description of the supported data types for BYTE_STREAM_SPLIT.

### Are these changes tested?

No (only a doc change).

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41748

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants