GH-41688: [Dev] Include all relevant CMakeLists.txt files in cmake-format precommit hook#41689
Merged
jorisvandenbossche merged 2 commits intoapache:mainfrom May 17, 2024
Conversation
…ake-format precommit hook
|
|
raulcd
approved these changes
May 16, 2024
Member
raulcd
left a comment
There was a problem hiding this comment.
Not an expert on those regex but the change LGTM
kou
approved these changes
May 16, 2024
.pre-commit-config.yaml
Outdated
Comment on lines
+126
to
+130
| ?^cpp/cmake_modules/FindPythonLibsNew\.cmake$| | ||
| ?^cpp/cmake_modules/UseCython\.cmake$| | ||
| ?^cpp/src/arrow/util/config\.h\.cmake$| | ||
| ?^ci/conan/all/.*CMakeLists\.txt$| |
Member
There was a problem hiding this comment.
Could you sort this list in alphabetical order?
Suggested change
| ?^cpp/cmake_modules/FindNumPy\.cmake$| | |
| ?^cpp/cmake_modules/FindPythonLibsNew\.cmake$| | |
| ?^cpp/cmake_modules/UseCython\.cmake$| | |
| ?^cpp/src/arrow/util/config\.h\.cmake$| | |
| ?^ci/conan/all/.*CMakeLists\.txt$| | |
| ?^ci/conan/all/.*CMakeLists\.txt$| | |
| ?^cpp/cmake_modules/FindNumPy\.cmake$| | |
| ?^cpp/cmake_modules/FindPythonLibsNew\.cmake$| | |
| ?^cpp/cmake_modules/UseCython\.cmake$| | |
| ?^cpp/src/arrow/util/config\.h\.cmake$| |
.pre-commit-config.yaml
Outdated
Comment on lines
+119
to
+122
| ?^ci/.*/.*\.cmake$| | ||
| ?^cpp/.*/.*\.cmake\.in$| | ||
| ?^cpp/.*/.*\.cmake$| | ||
| ?^cpp/.*/CMakeLists\.txt$| | ||
| ?^go/.*/CMakeLists\.txt$| | ||
| ?^java/.*/CMakeLists\.txt$| | ||
| ?^matlab/.*/CMakeLists\.txt$| | ||
| ?^python/.*/CMakeLists\.txt$| | ||
| ?.*CMakeLists\.txt$| |
Member
There was a problem hiding this comment.
Could you sort this list in alphabetical order?
?.*CMakeLists\.txt$|
?^ci/.*/.*\.cmake$|
?^cpp/.*/.*\.cmake\.in$|
?^cpp/.*/.*\.cmake$|
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 14b8ca5. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…ake-format precommit hook (apache#41689) ### Rationale for this change Some CMakeLists.txt files are not included in the pre-commit hook (causing failures on CI through archery if you rely on the pre-commit hook locally) ### What changes are included in this PR? Include all CMakeLists.txt files by default anywhere in the repo, and explicitly exclude the ones we don't want (vendored files). In practice, compared to the current set of files covered by the hook, those new files are included in the search: 'cpp/CMakeLists.txt', 'java/CMakeLists.txt', 'matlab/CMakeLists.txt', 'python/CMakeLists.txt' ### Are these changes tested? Yes * GitHub Issue: apache#41688 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Some CMakeLists.txt files are not included in the pre-commit hook (causing failures on CI through archery if you rely on the pre-commit hook locally)
What changes are included in this PR?
Include all CMakeLists.txt files by default anywhere in the repo, and explicitly exclude the ones we don't want (vendored files).
In practice, compared to the current set of files covered by the hook, those new files are included in the search:
'cpp/CMakeLists.txt',
'java/CMakeLists.txt',
'matlab/CMakeLists.txt',
'python/CMakeLists.txt'
Are these changes tested?
Yes