GH-41089: [C++] Clean up remaining tasks related to half float casts #41084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
Could you open a new issue for this? |
Contributor
Author
Sure, filed #41089 |
|
|
pitrou
reviewed
Apr 9, 2024
|
|
||
| // Slightly adapted from values present here | ||
| // https://blogs.mathworks.com/cleve/2017/05/08/half-precision-16-bit-floating-point-arithmetic/ | ||
| AssertFormatting(formatter, Float16::FromBits(0x3c00).bits(), "1"); |
Member
There was a problem hiding this comment.
This can certainly be simplified to 0x3c00, no?
Contributor
Author
There was a problem hiding this comment.
Good point, simplified.
pitrou
approved these changes
Apr 10, 2024
Member
pitrou
left a comment
There was a problem hiding this comment.
Thanks for the update @ClifHouck . This looks good to me.
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 71ec6d4. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…casts (apache#41084) ### Rationale for this change Address remaining tasks brought up post-merge in this PR: apache#40067 ### What changes are included in this PR? Adds a couple of tests and cleans up cruft on another test. ### Are these changes tested? Yes, as these are test-only related changes. ### Are there any user-facing changes? No. * GitHub Issue: apache#41089 Authored-by: Clif Houck <me@clifhouck.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Address remaining tasks brought up post-merge in this PR: #40067
What changes are included in this PR?
Adds a couple of tests and cleans up cruft on another test.
Are these changes tested?
Yes, as these are test-only related changes.
Are there any user-facing changes?
No.