GH-41043: [CI][Python] check message in test_make_write_options_error for Cython 2#41059
Merged
raulcd merged 2 commits intoapache:mainfrom Apr 10, 2024
Merged
GH-41043: [CI][Python] check message in test_make_write_options_error for Cython 2#41059raulcd merged 2 commits intoapache:mainfrom
raulcd merged 2 commits intoapache:mainfrom
Conversation
Member
Author
|
@github-actions crossbow submit test-conda-python-3.10-cython2 |
|
Revision: 3d92297 Submitted crossbow builds: ursacomputing/crossbow @ actions-c993a5b07c
|
Member
Author
|
@github-actions crossbow submit test-conda-python-3.10-cython2 |
|
Revision: 6ca5fe3 Submitted crossbow builds: ursacomputing/crossbow @ actions-f5869d858a
|
pitrou
approved these changes
Apr 8, 2024
Member
|
Thanks for the fix @AlenkaF ! |
raulcd
approved these changes
Apr 10, 2024
raulcd
pushed a commit
that referenced
this pull request
Apr 10, 2024
… for Cython 2 (#41059) ### Rationale for this change `test_make_write_options_error` has been failing on Cython 2 crossbow build because in older versions of Cython the methods were "regular" C extension method had type check automatically built in. In Cython 3 that is not the case, see cython/cython#6127 and so the check for `ParquetFileFormat` was added in #40976. ### What changes are included in this PR? Checking the error raised for both messages, type check and the check for `ParquetFileFormat` added in #40976. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #41043 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 376a271. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…_error for Cython 2 (apache#41059) ### Rationale for this change `test_make_write_options_error` has been failing on Cython 2 crossbow build because in older versions of Cython the methods were "regular" C extension method had type check automatically built in. In Cython 3 that is not the case, see cython/cython#6127 and so the check for `ParquetFileFormat` was added in apache#40976. ### What changes are included in this PR? Checking the error raised for both messages, type check and the check for `ParquetFileFormat` added in apache#40976. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#41043 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
test_make_write_options_errorhas been failing on Cython 2 crossbow build because in older versions of Cython the methods were "regular" C extension method had type check automatically built in. In Cython 3 that is not the case, see cython/cython#6127 and so the check forParquetFileFormatwas added in #40976.What changes are included in this PR?
Checking the error raised for both messages, type check and the check for
ParquetFileFormatadded in #40976.Are these changes tested?
Yes.
Are there any user-facing changes?
No.