GH-40799: [Doc][Format] Implementation status page should list canonical extension types#41053
Merged
rok merged 3 commits intoapache:mainfrom Apr 8, 2024
Merged
GH-40799: [Doc][Format] Implementation status page should list canonical extension types#41053rok merged 3 commits intoapache:mainfrom
rok merged 3 commits intoapache:mainfrom
Conversation
|
|
Member
Author
|
@github-actions crossbow submit preview-docs |
|
Revision: ae56dec Submitted crossbow builds: ursacomputing/crossbow @ actions-cdc4d5be63
|
Member
Author
jorisvandenbossche
approved these changes
Apr 8, 2024
pitrou
reviewed
Apr 8, 2024
docs/source/status.rst
Outdated
Comment on lines
+118
to
+120
| | FixedShapeTensor | ✓ | | | | | | | | | ||
| +---------------------+-------+-------+-------+------------+-------+-------+-------+-------+ | ||
| | VariableShapeTensor | | | | | | | | | |
Member
There was a problem hiding this comment.
These are the C++ and Python internal names, should we use the prose spelling instead? "Fixed shape tensor" and "Variable shape tensor"
Member
Author
There was a problem hiding this comment.
Good point, thanks for catching this! Fixed.
rok
commented
Apr 8, 2024
rok
commented
Apr 8, 2024
pitrou
approved these changes
Apr 8, 2024
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 072eff3. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
raulcd
pushed a commit
that referenced
this pull request
Apr 9, 2024
…cal extension types (#41053) ### Rationale for this change Two specifications and one implementation of canonical extension types were added and this should be documented. ### What changes are included in this PR? This represents current state of canonical extension types. ### Are these changes tested? No, docs only. ### Are there any user-facing changes? In so much as they read docs. * GitHub Issue: #40799 Authored-by: Rok Mihevc <rok@mihevc.org> Signed-off-by: Rok Mihevc <rok@mihevc.org>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…canonical extension types (apache#41053) ### Rationale for this change Two specifications and one implementation of canonical extension types were added and this should be documented. ### What changes are included in this PR? This represents current state of canonical extension types. ### Are these changes tested? No, docs only. ### Are there any user-facing changes? In so much as they read docs. * GitHub Issue: apache#40799 Authored-by: Rok Mihevc <rok@mihevc.org> Signed-off-by: Rok Mihevc <rok@mihevc.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Two specifications and one implementation of canonical extension types were added and this should be documented.
What changes are included in this PR?
This represents current state of canonical extension types.
Are these changes tested?
No, docs only.
Are there any user-facing changes?
In so much as they read docs.