GH-41024: [C++] IO: fixing compiling in gcc 7.5.0#41025
Merged
kou merged 1 commit intoapache:mainfrom Apr 5, 2024
Merged
Conversation
Member
Author
|
cc @kou |
|
|
Member
|
@github-actions crossbow submit test-r-rstudio-r-base-4.1-opensuse153 |
|
Revision: e563385 Submitted crossbow builds: ursacomputing/crossbow @ actions-48f01dbd0f
|
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 110efed. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
### Rationale for this change Previous pr ( apache#39807 ) remove std::move when returning value, however, it's not allowed in some old compilers ### What changes are included in this PR? add std::move for return, and add reason for that ### Are these changes tested? Should test by other ci ### Are there any user-facing changes? no * GitHub Issue: apache#41024 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Previous pr ( #39807 ) remove std::move when returning value, however, it's not allowed in some old compilers
What changes are included in this PR?
add std::move for return, and add reason for that
Are these changes tested?
Should test by other ci
Are there any user-facing changes?
no