GH-40999: [Java] Fix AIOOBE trying to splitAndTransfer DUV within nullable struct #41000
GH-40999: [Java] Fix AIOOBE trying to splitAndTransfer DUV within nullable struct #41000lidavidm merged 1 commit intoapache:mainfrom
Conversation
|
|
…failed with AIOOBE
947f8fc to
c98e143
Compare
|
@github-actions crossbow submit java |
vibhatha
left a comment
There was a problem hiding this comment.
Thanks for making this PR. LGTM!
Running the crossbows...
|
Revision: c98e143 Submitted crossbow builds: ursacomputing/crossbow @ actions-b831aa40e2
|
lidavidm
left a comment
There was a problem hiding this comment.
Hmm. This is still copying garbage around, right? I suppose with most vectors, it just doesn't matter. And we have no way of knowing that this slot is actually undefined here.
|
@lidavidm yep, t'is. I'm not sure you'd want to avoid it, in this case - this way, you get to copy contiguous child buffers. Otherwise, IIUC, to avoid copying garbage you'd have to copy individual entries? Thanks for merging the PR btw |
|
To avoid copying garbage I think you'd have to always zero-initialize with the way we've built these APIs. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 84f6ede. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
…in nullable struct (apache#41000) We add a `typeId >= 0` guard to `DUV.TransferImpl.splitAndTransfer` to fix apache#40999. ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#40999 Authored-by: James Henderson <james@jarohen.dev> Signed-off-by: David Li <li.davidm96@gmail.com>
…in nullable struct (apache#41000) We add a `typeId >= 0` guard to `DUV.TransferImpl.splitAndTransfer` to fix apache#40999. ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#40999 Authored-by: James Henderson <james@jarohen.dev> Signed-off-by: David Li <li.davidm96@gmail.com>
We add a
typeId >= 0guard toDUV.TransferImpl.splitAndTransferto fix #40999.Are these changes tested?
Yes
Are there any user-facing changes?
No