GH-40994: [C++][Parquet] RleBooleanDecoder supports DecodeArrow with nulls#40995
Merged
pitrou merged 9 commits intoapache:mainfrom Apr 4, 2024
Merged
GH-40994: [C++][Parquet] RleBooleanDecoder supports DecodeArrow with nulls#40995pitrou merged 9 commits intoapache:mainfrom
pitrou merged 9 commits intoapache:mainfrom
Conversation
|
|
34d3c72 to
8a33bea
Compare
Member
Author
pitrou
reviewed
Apr 4, 2024
pitrou
reviewed
Apr 4, 2024
Member
Author
|
benchmark number wouldn't be great, because RleDecoder need to decode to |
Member
|
Well, it seems the benchmarks fail: |
Member
Author
|
Testing on My PC ( Amd 3800X, WSL2, gcc11.4, Release(-O2) ) RLE PLAIN: For all-nulls seems that Rle is faster because it hacks the logic without any checking |
5e31baa to
cb1a842
Compare
wgtmac
reviewed
Apr 4, 2024
|
|
||
| TYPED_TEST(EncodingAdHocTyped, RleArrowDirectPut) { | ||
| // TODO: test with nulls once RleBooleanDecoder::DecodeArrow supports them | ||
| this->null_probability_ = 0; |
Member
Author
There was a problem hiding this comment.
Hmm what does this mean? The case is covered here
Member
|
@github-actions crossbow submit -g cpp |
|
Revision: cb1a842 Submitted crossbow builds: ursacomputing/crossbow @ actions-35133d7bec
|
…row into rle-boolean-impl-decode-arrow
pitrou
reviewed
Apr 4, 2024
cpp/src/parquet/encoding.cc
Outdated
| current_index_in_batch = 0; | ||
| }; | ||
| if (null_count == 0) { | ||
| int sum_decode_count = 0; |
Member
There was a problem hiding this comment.
Why introduce a separate variable? We know that we're going to return the original value of num_values.
Member
Author
There was a problem hiding this comment.
Removed it, it's copy-pasted from origin impl
pitrou
requested changes
Apr 4, 2024
Member
pitrou
left a comment
There was a problem hiding this comment.
Please simplify the code a bit. There's a bunch of local variables which are mutually redundant.
pitrou
approved these changes
Apr 4, 2024
Member
|
This is a nice improvement, thank you @mapleFU ! |
pitrou
pushed a commit
that referenced
this pull request
Apr 8, 2024
…oding (#41037) ### Rationale for this change Previous patches ( #40876 , #40995 ) introduce some bugs in boolean decoding. This patch add tests for DecodeArrow and fix the bug ### What changes are included in this PR? 1. Add tests for DecodeArrow with nulls and without nulls 2. Fix 2 bugs ### Are these changes tested? Yes ### Are there any user-facing changes? no * GitHub Issue: #41032 Lead-authored-by: mwish <maplewish117@gmail.com> Co-authored-by: mwish <anmmscs_maple@qq.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
… with nulls (apache#40995) ### Rationale for this change Supports DecodeArrow with nulls in RleBooleanDecoder ### What changes are included in this PR? Supports DecodeArrow with nulls in RleBooleanDecoder ### Are these changes tested? Yes ### Are there any user-facing changes? currently not * GitHub Issue: apache#40994 Lead-authored-by: mwish <maplewish117@gmail.com> Co-authored-by: mwish <anmmscs_maple@qq.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…ow decoding (apache#41037) ### Rationale for this change Previous patches ( apache#40876 , apache#40995 ) introduce some bugs in boolean decoding. This patch add tests for DecodeArrow and fix the bug ### What changes are included in this PR? 1. Add tests for DecodeArrow with nulls and without nulls 2. Fix 2 bugs ### Are these changes tested? Yes ### Are there any user-facing changes? no * GitHub Issue: apache#41032 Lead-authored-by: mwish <maplewish117@gmail.com> Co-authored-by: mwish <anmmscs_maple@qq.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b99b00d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Supports DecodeArrow with nulls in RleBooleanDecoder
What changes are included in this PR?
Supports DecodeArrow with nulls in RleBooleanDecoder
Are these changes tested?
Yes
Are there any user-facing changes?
currently not