Skip to content

GH-40806: [C++] Revert changes from PR #40857#40980

Merged
pitrou merged 1 commit intomainfrom
revert-40857-cpu-info-asimd
Apr 4, 2024
Merged

GH-40806: [C++] Revert changes from PR #40857#40980
pitrou merged 1 commit intomainfrom
revert-40857-cpu-info-asimd

Conversation

@pitrou
Copy link
Copy Markdown
Member

@pitrou pitrou commented Apr 3, 2024 •
edited by github-actions bot
Loading

Revert changes from #40857.

GetRuntimeInfo returns the SIMD level for dynamic dispatch, but Neon currently does not participate in dynamic dispatch (actually, Neon should be available by default on all modern Arm CPUs AFAIU).

@pitrou pitrou requested a review from cyb70289 April 3, 2024 15:48
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2024

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@pitrou pitrou mentioned this pull request Apr 3, 2024
Merged
@pitrou pitrou requested a review from kou April 3, 2024 15:50
@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Apr 3, 2024

@github-actions crossbow submit wheelarm*

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Apr 4, 2024
@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Apr 4, 2024

@github-actions crossbow submit wheelarm

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2024

Revision: 1dc5dbc

Submitted crossbow builds: ursacomputing/crossbow @ actions-25962665e2

Task Status
wheel-macos-big-sur-cp310-arm64 GitHub Actions
wheel-macos-big-sur-cp311-arm64 GitHub Actions
wheel-macos-big-sur-cp312-arm64 GitHub Actions
wheel-macos-big-sur-cp38-arm64 GitHub Actions
wheel-macos-big-sur-cp39-arm64 GitHub Actions
wheel-manylinux-2-28-cp310-arm64 GitHub Actions
wheel-manylinux-2-28-cp311-arm64 GitHub Actions
wheel-manylinux-2-28-cp312-arm64 GitHub Actions
wheel-manylinux-2-28-cp38-arm64 GitHub Actions
wheel-manylinux-2-28-cp39-arm64 GitHub Actions
wheel-manylinux-2014-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp311-arm64 GitHub Actions
wheel-manylinux-2014-cp312-arm64 GitHub Actions
wheel-manylinux-2014-cp38-arm64 GitHub Actions
wheel-manylinux-2014-cp39-arm64 GitHub Actions

@pitrou pitrou changed the title Revert "GH-40806: [C++] Correctly report asimd/neon in GetRuntimeInfo" GH-40806: [C++] Revert changes from PR #40857 Apr 4, 2024
@pitrou pitrou merged commit 26631d7 into main Apr 4, 2024
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Apr 4, 2024
@pitrou pitrou deleted the revert-40857-cpu-info-asimd branch April 4, 2024 08:29
@conbench-apache-arrow
Copy link
Copy Markdown

conbench-apache-arrow bot commented Apr 4, 2024

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 26631d7.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
@pitrou @vibhatha
apacheGH-40806: [C++] Revert changes from PR apache#40857 (apache#40980)
502a93b 
Revert changes from apache#40857.

`GetRuntimeInfo` returns the SIMD level for dynamic dispatch, but Neon currently does not participate in dynamic dispatch (actually, Neon should be available by default on all modern Arm CPUs AFAIU).

Authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyb70289 cyb70289 cyb70289 approved these changes

@kou kou Awaiting requested review from kou

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pitrou @cyb70289