GH-40974: [CI][Python] CI failures on Python builds due to pytest_cython #40975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danepitkin
approved these changes
Apr 3, 2024
Member
danepitkin
left a comment
There was a problem hiding this comment.
LGTM! added one comment about tracking unpinning
docker-compose.yml
Outdated
| # pytest-cython needs an upper pin of 0.3.0 due | ||
| # to an issue with typing annotiations | ||
| # https://github.com/lgpage/pytest-cython/issues/67 | ||
| # With 0.3.* bug fix release, the pin can be removed |
Member
There was a problem hiding this comment.
Is it worth creating a GH issue to unpin and add the issue # in the comment here?
kou
reviewed
Apr 4, 2024
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit bbeeb33. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…st_cython (apache#40975) ### Rationale for this change We are seeing sporadic CI failures on Python builds due to `pytest_cython`. ### What changes are included in this PR? Upper pin of 0.3.0 added for `pytest-cython`. ### Are these changes tested? With a green CI. ### Are there any user-facing changes? No. * GitHub Issue: apache#40974 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We are seeing sporadic CI failures on Python builds due to
pytest_cython.What changes are included in this PR?
Upper pin of 0.3.0 added for
pytest-cython.Are these changes tested?
With a green CI.
Are there any user-facing changes?
No.