Skip to content

MINOR: [CI] Avoid docker-compose on Azure#40972

Merged
pitrou merged 3 commits intoapache:mainfrom
pitrou:azure-docker
Apr 3, 2024
Merged

MINOR: [CI] Avoid docker-compose on Azure#40972
pitrou merged 3 commits intoapache:mainfrom
pitrou:azure-docker

Conversation

@pitrou
Copy link
Copy Markdown
Member

@pitrou pitrou commented Apr 3, 2024

Rationale for this change

Same as PR #40949, but for Crossbow builds hosted on Azure Pipelines.

Are these changes tested?

Yes, they fix CI tests.

Are there any user-facing changes?

No.

@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Apr 3, 2024

@github-actions crossbow submit conda-clean test-debian-12-python-3-amd64

@github-actions github-actions bot added the awaiting review Awaiting review label Apr 3, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2024

Revision: 1d321c4

Submitted crossbow builds: ursacomputing/crossbow @ actions-2c5940b7be

Task Status
conda-clean Azure
test-debian-12-python-3-amd64 Azure

@pitrou pitrou marked this pull request as ready for review April 3, 2024 08:53
@pitrou pitrou requested review from assignUser, kou and raulcd as code owners April 3, 2024 08:53
@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Apr 3, 2024

@assignUser @kou Can you advise?

uses: actions/setup-python@v5.1.0
with:
python-version: '3.12'
python-version: '3.9'
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required for the docker-compose dependencies to install properly.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Apr 3, 2024
@pitrou pitrou merged commit 469430f into apache:main Apr 3, 2024
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Apr 3, 2024
@pitrou pitrou deleted the azure-docker branch April 3, 2024 11:52
Copy link
Copy Markdown
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting everything going again! Sorry for the late review.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Apr 3, 2024
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 469430f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
### Rationale for this change

Same as PR apache#40949, but for Crossbow builds hosted on Azure Pipelines.

### Are these changes tested?

Yes, they fix CI tests.

### Are there any user-facing changes?

No.

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting committer review Awaiting committer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants