GH-40863: [C++] Fix TSAN link error for module library #40864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
pitrou
approved these changes
Mar 28, 2024
Member
|
@github-actions crossbow submit -g cpp |
|
Revision: a8c7efa Submitted crossbow builds: ursacomputing/crossbow @ actions-726f7f5beb
|
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit cf832b8. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…40864) ### Rationale for this change Module library `arrow_filesystem_example` is introduced in apache#39067 for filesystem testing: https://github.com/apache/arrow/blob/6cecbab5172b2b339277dde741bfff455646eb32/cpp/src/arrow/testing/CMakeLists.txt#L25 However when built with TSAN, linker flags such as `-fsanitize=thread` is not set, causing the link error in apache#40863. ### What changes are included in this PR? Add necessary linker flags for module library. ### Are these changes tested? Manually tested. ### Are there any user-facing changes? None. * GitHub Issue: apache#40863 Authored-by: Ruoxi Sun <zanmato1984@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Module library
arrow_filesystem_exampleis introduced in #39067 for filesystem testing:arrow/cpp/src/arrow/testing/CMakeLists.txt
Line 25 in 6cecbab
However when built with TSAN, linker flags such as
-fsanitize=threadis not set, causing the link error in #40863.What changes are included in this PR?
Add necessary linker flags for module library.
Are these changes tested?
Manually tested.
Are there any user-facing changes?
None.