GH-40858: [R] Remove dangling commas from codegen.R#40859
Conversation
|
|
paleolimbot
left a comment
There was a problem hiding this comment.
This looks good to me...thanks! I am also puzzled as to why this happened and why it happened now (particularly since it looks like glue hasn't been updated for some time). Either way, happy to do what we need to do to make your development life easier 🙂
|
Thanks @paleolimbot. Before I merge, I'm going to find the root cause just so we know. I can't reproduce the original issue on my work machine which is on R 4.3.2 (versus 4.3.3) and glue 1.7.0 (versus 1.6.2). |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 1feb945. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change This is a draft PR fixing apache#40858, though I'm not sure how or why this broke (or worked correctly). Fixes apache#40858 ### Are these changes tested? These have been tested locally. * GitHub Issue: apache#40858 Authored-by: Bryce Mecum <petridish@gmail.com> Signed-off-by: Bryce Mecum <petridish@gmail.com>
Rationale for this change
This is a draft PR fixing #40858, though I'm not sure how or why this broke (or worked correctly).
Fixes #40858
Are these changes tested?
These have been tested locally.