Skip to content

GH-40454: [CI][Debian] Update Debian to 12 from 11 #40455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raulcd merged 4 commits into from
Mar 13, 2024
Merged

GH-40454: [CI][Debian] Update Debian to 12 from 11 #40455

raulcd merged 4 commits into from
Mar 13, 2024

Conversation

@kou
Copy link
Member

@kou kou commented Mar 11, 2024 •
edited
Loading

Rationale for this change

Debian 11 will reach EOL on 2024-07.

What changes are included in this PR?

  • Use Debian 12.
  • Enable build options that can't be enabled with Debian 11.
    • ARROW_AZURE
    • ARROW_FLIGHT_SQL
    • ARROW_WITH_OPENTELEMETRY

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou kou requested review from assignUser and raulcd as code owners March 11, 2024 07:01
@kou
Copy link
Member Author

kou commented Mar 11, 2024

@github-actions crossbow submit test-debian-*

@github-actions
Copy link

github-actions bot commented Mar 11, 2024

⚠️ GitHub issue #40454 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Mar 11, 2024
@github-actions

This comment was marked as outdated.

Sign in to view
@kou kou force-pushed the ci-debian-12 branch 2 times, most recently from 278e136 to 53c3ff3 Compare March 11, 2024 07:25
@kou
Copy link
Member Author

kou commented Mar 11, 2024

@github-actions crossbow submit test-debian-*

@github-actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Mar 11, 2024

@github-actions crossbow submit test-debian-*

@github-actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Mar 11, 2024

@github-actions crossbow submit test-debian-*

@github-actions

This comment was marked as outdated.

Sign in to view
@kou
apacheGH-40454: [CI][Debian] Update Debian to 12 from 11
281c437 
Debian 11 will reach EOL on 2024-07.
@kou
Copy link
Member Author

kou commented Mar 11, 2024

@github-actions crossbow submit test-debian-*

@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd
Copy link
Member

raulcd commented Mar 11, 2024

@github-actions crossbow submit -g python

raulcd
raulcd reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou Thanks for the PR! this is great. We are doing other things on this PR apart from updating debian version, like enabling AZURE build, etc. I am ok with it but should we reference it on the title/description or do it on a different PR?

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Mar 11, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Mar 11, 2024
@kou
Copy link
Member Author

kou commented Mar 11, 2024

We are doing other things on this PR apart from updating debian version, like enabling AZURE build, etc. I am ok with it but should we reference it on the title/description or do it on a different PR?

You're right. I've update the description. I keep the title for now because these changes are PR details. (Title should describes summary not details.)

@kou
Copy link
Member Author

kou commented Mar 11, 2024

@github-actions crossbow submit test-debian-12-python-3-i386

@github-actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Mar 11, 2024

@github-actions crossbow submit test-debian-12-python-3-amd64 -g python

@github-actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Mar 12, 2024

@github-actions crossbow submit -g python

@github-actions
Copy link

github-actions bot commented Mar 12, 2024

Revision: 429fcda

Submitted crossbow builds: ursacomputing/crossbow @ actions-81621861bb

Task Status
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest GitHub Actions
test-conda-python-3.10-pandas-nightly GitHub Actions
test-conda-python-3.10-spark-v3.5.0 GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-upstream_devel GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.8 GitHub Actions
test-conda-python-3.8-pandas-1.0 GitHub Actions
test-conda-python-3.8-spark-v3.5.0 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-latest GitHub Actions
test-cuda-python GitHub Actions
test-debian-12-python-3-amd64 Azure
test-debian-12-python-3-i386 GitHub Actions
test-fedora-39-python-3 Azure
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-python-3 GitHub Actions

@raulcd
Copy link
Member

raulcd commented Mar 12, 2024

@github-actions crossbow submit test-debian-12*

@github-actions
Copy link

github-actions bot commented Mar 12, 2024

Revision: 8039954

Submitted crossbow builds: ursacomputing/crossbow @ actions-fd91db0a83

Task Status
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-debian-12-go-1.19 Azure
test-debian-12-go-1.21 Azure
test-debian-12-python-3-amd64 Azure
test-debian-12-python-3-i386 GitHub Actions

@kou
Copy link
Member Author

kou commented Mar 12, 2024

Can we merge this?

raulcd
raulcd approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kou !

@raulcd raulcd merged commit 9381647 into apache:main Mar 13, 2024
@raulcd raulcd removed the awaiting change review Awaiting change review label Mar 13, 2024
@raulcd raulcd mentioned this pull request Mar 13, 2024
Closed
@github-actions github-actions bot added the awaiting merge Awaiting merge label Mar 13, 2024
@Tom-Newton Tom-Newton mentioned this pull request Mar 13, 2024
Merged
@kou kou deleted the ci-debian-12 branch March 13, 2024 20:32
@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Mar 13, 2024

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 9381647.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

This was referenced Mar 14, 2024
Closed
Merged
kou added a commit that referenced this pull request Mar 16, 2024
@raulcd @kou
GH-40535: [Docs][R] Set RETICULATE_PYTHON_ENV in order to find pyarrow (
b448b33 
#40571)

### Rationale for this change

With the changes in #40455 reticulate can't find pyarrow.

### What changes are included in this PR?

Set `RETICULATE_PYTHON_ENV` to `ARROW_PYTHON_VENV`.
See https://rstudio.github.io/reticulate/articles/versions.html#order-of-discovery why we can use `RETICULATE_PYTHON_ENV`.

This also simplifies the current configurations:
* Install Meson by `apt-get`.
* Use `ARROW_PYTHON_VENV` to install Sphinx and related packages.

### Are these changes tested?

Via archery.

### Are there any user-facing changes?

No
* GitHub Issue: #40535

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raulcd raulcd raulcd approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

Assignees

No one assigned

Labels

awaiting merge Awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kou @raulcd