GH-40060: [C++][Python] Basic conversion of RecordBatch to Arrow Tensor - add support for different data types#40359
Merged
jorisvandenbossche merged 22 commits intoapache:mainfrom Mar 26, 2024
Conversation
|
|
Member
Author
|
@zeroshade would you mind reviewing this feature also? |
fcfac4a to
1fbaec9
Compare
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Member
Author
|
@bkietz the only question left open is the |
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
jorisvandenbossche
approved these changes
Mar 26, 2024
Member
jorisvandenbossche
left a comment
There was a problem hiding this comment.
OK, looking good now!
I am going to merge this so Alenka can open the follow-up PRs, but so if there is any remaining comment that can be addressed there.
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 434f872. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
RecordBatcheswith fields of different type in the conversionRecordBatch→Tensor.RecordBatch.to_tensor()docstrings, see GH-40059: [C++][Python] Basic conversion of RecordBatch to Arrow Tensor #40064 (comment).Are these changes tested?
Yes.
Are there any user-facing changes?
No.