GH-40085: [C++][FS][Azure] Validate containers in AzureFileSystem::Impl::MovePaths()#40086
Merged
felipecrv merged 3 commits intoapache:mainfrom Feb 15, 2024
Merged
Conversation
|
|
Contributor
Author
b44d92c to
c51c3d9
Compare
c51c3d9 to
9f98d8f
Compare
kou
approved these changes
Feb 15, 2024
Comment on lines
+1255
to
+1256
| another_container + "/path"), | ||
| fs()->Move(data.ObjectPath(), another_container + "/path")); |
Member
There was a problem hiding this comment.
Could you use ConcatAbstractPath()?
Suggested change
| another_container + "/path"), | |
| fs()->Move(data.ObjectPath(), another_container + "/path")); | |
| ConcatAbstractPath(another_container, "path")), | |
| fs()->Move(data.ObjectPath(), ConcatAbstractPath(another_container, "path"))); |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 621f707. There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…em::Impl::MovePaths() (apache#40086) ### Rationale for this change Cross container moves aren't supported yet (and might never be). ### What changes are included in this PR? - Check that containers are the same before calling a `Rename` that assumes `src` and `dest` are on the same container ### Are these changes tested? Yes, new tests were added. * Closes: apache#40085 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Cross container moves aren't supported yet (and might never be).
What changes are included in this PR?
Renamethat assumessrcanddestare on the same containerAre these changes tested?
Yes, new tests were added.