GH-40055: [Java][Docs] Simplify use of Filter and Expression into Dataset Substrait#40056
Conversation
|
|
| .. code-block:: text | ||
|
|
||
| ADD_TEN_TO_COLUMN_N_REGIONKEY CONCAT_COLUMNS_N_NAME_AND_N_COMMENT | ||
| column-1 column-2 |
There was a problem hiding this comment.
@davisusanibar I guess this column name changes occur from the Substrait end?
There was a problem hiding this comment.
Yes, it is.
I just created this issue for enhancements "Produce projection/filter extended expressions with predefined column names" substrait-io/substrait-java#229
| while (reader.loadNextBatch()) { | ||
| System.out.println( | ||
| reader.getVectorSchemaRoot().contentToTSVString()); | ||
| System.out.println(reader.getVectorSchemaRoot().contentToTSVString()); |
There was a problem hiding this comment.
nit: does this need formatting. I am merely asking this comparing with the existing code.
There was a problem hiding this comment.
I'll review how a linter will be configured/implemented for Java code.
vibhatha
left a comment
There was a problem hiding this comment.
@davisusanibar thank you for working on this. PR LGTM!
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a03d957. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…to Dataset Substrait (apache#40056) ### Rationale for this change Simplify creation of SQL Expression Filter and Projections into Arrow Java Dataset module using new [Substrait Feature for SQL Expressions](https://github.com/substrait-io/substrait-java/releases/tag/v0.26.0). ### What changes are included in this PR? Update Apache Arrow Java Dataset Substrait documentation ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#40055 Authored-by: david dali susanibar arce <davi.sarces@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Rationale for this change
Simplify creation of SQL Expression Filter and Projections into Arrow Java Dataset module using new Substrait Feature for SQL Expressions.
What changes are included in this PR?
Update Apache Arrow Java Dataset Substrait documentation
Are these changes tested?
Yes
Are there any user-facing changes?
No