GH-39463: [C++] Support cast kernel from large string, (large) binary to dictionary#40017
Merged
felipecrv merged 2 commits intoapache:mainfrom Feb 14, 2024
Merged
GH-39463: [C++] Support cast kernel from large string, (large) binary to dictionary#40017felipecrv merged 2 commits intoapache:mainfrom
felipecrv merged 2 commits intoapache:mainfrom
Conversation
felipecrv
reviewed
Feb 13, 2024
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2422994. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…binary to dictionary (apache#40017) ### Rationale for this change Support `cast` kernel from large string(`large_utf8()`, (large) binary(`binary()`, `large_binary()`) to `dictionary` ### What changes are included in this PR? - Support `cast` kernel - from large string(`large_utf8()`) to `dictionary` - from binary(`binary()`) to `dictionary` - from large binary(`large_binary()`) to `dictionary` ### Are these changes tested? Yes. It is passed by existing test cases. ### Are there any user-facing changes? No. * Closes: apache#39463 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Support
castkernel from large string(large_utf8(), (large) binary(binary(),large_binary()) todictionaryWhat changes are included in this PR?
castkernellarge_utf8()) todictionarybinary()) todictionarylarge_binary()) todictionaryAre these changes tested?
Yes. It is passed by existing test cases.
Are there any user-facing changes?
No.