Skip to content

GH-40011: [CI] Update Fedora to 39 from 38#40012

Merged
raulcd merged 3 commits intoapache:mainfrom
kou:ci-fedora-39
Feb 10, 2024
Merged

GH-40011: [CI] Update Fedora to 39 from 38#40012
raulcd merged 3 commits intoapache:mainfrom
kou:ci-fedora-39

Conversation

@kou
Copy link
Copy Markdown
Member

@kou kou commented Feb 9, 2024 •
edited by github-actions bot
Loading

Rationale for this change

Fedora 39 is the latest release and Fedora 38 will reach EOL on 2024-05-14.

What changes are included in this PR?

Use Fedora 39.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
apacheGH-40011: [CI] Update Fedora to 39 from 38
18b5045 
Fedora 39 is the latest release and Fedora 38 will reach EOL on
2024-05-14.
@kou kou requested review from assignUser and raulcd as code owners February 9, 2024 01:19
@kou
Copy link
Copy Markdown
Member Author

kou commented Feb 9, 2024

@github-actions crossbow submit fedora

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 9, 2024

⚠️ GitHub issue #40011 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Feb 9, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 9, 2024

Revision: 18b5045

Submitted crossbow builds: ursacomputing/crossbow @ actions-9f3296e906

Task Status
example-python-minimal-build-fedora-conda GitHub Actions
test-fedora-39-cpp GitHub Actions
test-fedora-39-python-3 Azure
test-fedora-r-clang-sanitizer Azure

@kou
Copy link
Copy Markdown
Member Author

kou commented Feb 9, 2024

test-fedora-39-python-3 failure is #39695.

raulcd
raulcd reviewed Feb 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should update the fedora version on the minimal build examples too:
https://github.com/apache/arrow/blob/main/python/examples/minimal_build/Dockerfile.fedora#L18

diff --git a/python/examples/minimal_build/Dockerfile.fedora b/python/examples/minimal_build/Dockerfile.fedora
index cc3d62b..e7b9600 100644
--- a/python/examples/minimal_build/Dockerfile.fedora
+++ b/python/examples/minimal_build/Dockerfile.fedora
@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-FROM fedora:35
+FROM fedora:39
 
 RUN dnf update -y && \
     dnf install -y \

Can you do it here? I've tested locally with the change:

docker-compose run --rm minimal-fedora-conda
docker-compose run --rm minimal-fedora-venv

and both are successful.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Feb 9, 2024
kou and others added 2 commits February 10, 2024 06:38
@kou @raulcd
Update Dockerfile.fedora too
916fa77 
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
@kou
Don't run PyArrow's Gandiva test
bd5564b
@kou
Copy link
Copy Markdown
Member Author

kou commented Feb 9, 2024

Thanks! I missed it!

@kou
Copy link
Copy Markdown
Member Author

kou commented Feb 9, 2024

I disable PyArrow's Gandiva test for now.

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 9, 2024
@kou
Copy link
Copy Markdown
Member Author

kou commented Feb 9, 2024

@github-actions crossbow submit fedora

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 9, 2024

Revision: bd5564b

Submitted crossbow builds: ursacomputing/crossbow @ actions-917d4aa4e0

Task Status
example-python-minimal-build-fedora-conda GitHub Actions
test-fedora-39-cpp GitHub Actions
test-fedora-39-python-3 Azure
test-fedora-r-clang-sanitizer Azure

raulcd
raulcd approved these changes Feb 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 archery failure was flaky. I am re-running and will merge once successful

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Feb 10, 2024
@raulcd raulcd merged commit 9eebe64 into apache:main Feb 10, 2024
@raulcd raulcd removed the awaiting merge Awaiting merge label Feb 10, 2024
@kou kou deleted the ci-fedora-39 branch February 10, 2024 11:40
@conbench-apache-arrow
Copy link
Copy Markdown

conbench-apache-arrow bot commented Feb 10, 2024

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9eebe64.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@kou @raulcd @dgreiss
apacheGH-40011: [CI] Update Fedora to 39 from 38 (apache#40012)
4b956d2 
### Rationale for this change

Fedora 39 is the latest release and Fedora 38 will reach EOL on 2024-05-14.

### What changes are included in this PR?

Use Fedora 39.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#40011

Lead-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raulcd raulcd raulcd approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

Assignees

No one assigned

Labels

Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] Update Fedora to 39 from 38

2 participants

@kou @raulcd