GH-39987: [R] Make it possible to use a rtools libarrow on windows #39986
GH-39987: [R] Make it possible to use a rtools libarrow on windows #39986assignUser merged 3 commits intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
|
@github-actions crossbow submit r-binary-packages |
|
Revision: f405c66 Submitted crossbow builds: ursacomputing/crossbow @ actions-e8f1c270de
|
nealrichardson
left a comment
There was a problem hiding this comment.
Am I missing it, but where do we download from rwlinlib (specifically, https://github.com/rwinlib/arrow/archive/refs/tags/v13.0.0.zip right?)
| # pkg-config --libs libcurl | ||
| GCS_LIBS="-lcurl -lnormaliz -lssh2 -lgdi32 -lssl -lcrypto -lcrypt32 -lwldap32 \ | ||
| -lz -lws2_32 -lnghttp2 -ldbghelp" | ||
| # Test if pkg-config is available to use |
There was a problem hiding this comment.
Does Rtools always have pkg-config? If so, we can probably simplify things here since there's only one way to build on Windows.
There was a problem hiding this comment.
rtools43 does, not sure about older versions
|
|
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
We don't, since we added checksum verification in #37941 we use the artifactory for windows too. |
I think for CRAN submission we should use rwinlib. |
…39986) This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version. These changes can't be tested, there are no user facing changes for now. * Closes: #39987 Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit e1241e7. There was 1 benchmark result with an error:
There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
…ows (apache#39986) This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version. These changes can't be tested, there are no user facing changes for now. * Closes: apache#39987 Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
…39986) This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version. These changes can't be tested, there are no user facing changes for now. * Closes: #39987 Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
…39986) This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version. These changes can't be tested, there are no user facing changes for now. * Closes: #39987 Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
This enables the use of libarrow from rtools. This is currently only possible by cross compiling manually but will be part of a future rtools version.
These changes can't be tested, there are no user facing changes for now.