GH-39883: [CI][R][Windows] Use ci/scripts/install_minio.sh with Git bash#39929
Merged
kou merged 1 commit intoapache:mainfrom Feb 5, 2024
Merged
GH-39883: [CI][R][Windows] Use ci/scripts/install_minio.sh with Git bash#39929kou merged 1 commit intoapache:mainfrom
kou merged 1 commit intoapache:mainfrom
Conversation
|
|
Member
Author
|
+1 No objection. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 0415a60. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
… Git bash (apache#39929) ### Rationale for this change `curl` in Rtools can't be used on non Rtools' MSYS2 environment. Because `curl` in Rtools can't refer `/usr/ssl/certs/ca-bundle.crt` on non Rtools' MSYS2 environment. ### What changes are included in this PR? Use the `bash` in GitHub Actions Runner. `curl` in the environment works. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#39883 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
curlin Rtools can't be used on non Rtools' MSYS2 environment. Becausecurlin Rtools can't refer/usr/ssl/certs/ca-bundle.crton non Rtools' MSYS2 environment.What changes are included in this PR?
Use the
bashin GitHub Actions Runner.curlin the environment works.Are these changes tested?
Yes.
Are there any user-facing changes?
No.