Skip to content

GH-39910: [Go] Add func to load prepared statement from ActionCreatePreparedStatementResult#39913

Merged
zeroshade merged 1 commit intoapache:mainfrom
abandy:GH-39910
Feb 7, 2024
Merged

GH-39910: [Go] Add func to load prepared statement from ActionCreatePreparedStatementResult#39913
zeroshade merged 1 commit intoapache:mainfrom
abandy:GH-39910

Conversation

@abandy
Copy link
Copy Markdown
Contributor

@abandy abandy commented Feb 2, 2024

Currently, in order to create a PreparedStatement a DoAction call will always be made via the client. I need to be able to make a PreparedStatement from persisted data that will not trigger the DoAction call to the server.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 2, 2024

⚠️ GitHub issue #39910 has been automatically assigned in GitHub to PR creator.

@abandy abandy marked this pull request as ready for review February 2, 2024 16:29
@abandy abandy requested a review from zeroshade as a code owner February 2, 2024 16:29
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Feb 5, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 6, 2024
@abandy
Copy link
Copy Markdown
Contributor Author

abandy commented Feb 6, 2024

Updated the Load prepared statement to use a type defined in types.go and added a func that allows the prepared statement to execute a put without returning a flightinfo.

@zeroshade
Copy link
Copy Markdown
Member

Thanks @abandy!

@zeroshade zeroshade merged commit f609bb1 into apache:main Feb 7, 2024
@zeroshade zeroshade removed the awaiting change review Awaiting change review label Feb 7, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Feb 7, 2024
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f609bb1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…reatePreparedStatementResult (apache#39913)

Currently, in order to create a PreparedStatement a DoAction call will always be made via the client. I need to be able to make a PreparedStatement from persisted data that will not trigger the DoAction call to the server.
* Closes: apache#39910

Authored-by: Alva Bandy <abandy@live.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@abandy abandy deleted the GH-39910 branch April 2, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Go] Need to be able to create a PreparedStatement from a persisted data.

2 participants