GH-39057: [CI][C++][Go] Don't run jobs that use a self-hosted GitHub Actions Runner on fork#39903
Merged
kou merged 1 commit intoapache:mainfrom Feb 6, 2024
Merged
GH-39057: [CI][C++][Go] Don't run jobs that use a self-hosted GitHub Actions Runner on fork#39903kou merged 1 commit intoapache:mainfrom
kou merged 1 commit intoapache:mainfrom
Conversation
|
|
…itHub Actions Runner on fork We can't use `jobs.<job_id>.if` to reject jobs that use self-hosted GitHub Actions Runner because `jobs.<job_id>.if` is evaluated before `jobs.<job_id>.strategy.matrix`. https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif > Note: The `jobs.<job_id>.if` condition is evaluated before > `jobs.<job_id>.strategy.matrix` is applied. We can use output `jobs<job_id>.outputs` instead. See also: * https://docs.github.com/en/actions/using-jobs/defining-outputs-for-jobs * https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idoutputs
d91d4c6 to
6eaa127
Compare
Member
Author
|
This PR:
My fork:
|
Member
Author
|
I'll merge this in the next week if nobody objects this. |
Member
Author
|
+1 No objection. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 062c841. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…itHub Actions Runner on fork (apache#39903) ### Rationale for this change If jobs that use a self-hosted GitHub Actions Runner on fork are submitted on fork, they will timeout eventually and report noisy failure notifications. ### What changes are included in this PR? We can't use `jobs.<job_id>.if` to reject jobs that use self-hosted GitHub Actions Runner because `jobs.<job_id>.if` is evaluated before `jobs.<job_id>.strategy.matrix`. https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif > Note: The `jobs.<job_id>.if` condition is evaluated before > `jobs.<job_id>.strategy.matrix` is applied. We can use output `jobs<job_id>.outputs` instead. See also: * https://docs.github.com/en/actions/using-jobs/defining-outputs-for-jobs * https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idoutputs ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#39057 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
If jobs that use a self-hosted GitHub Actions Runner on fork are submitted on fork, they will timeout eventually and report noisy failure notifications.
What changes are included in this PR?
We can't use
jobs.<job_id>.ifto reject jobs that use self-hosted GitHub Actions Runner becausejobs.<job_id>.ifis evaluated beforejobs.<job_id>.strategy.matrix.https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif
We can use output
jobs<job_id>.outputsinstead. See also:Are these changes tested?
Yes.
Are there any user-facing changes?
No.