GH-39900: [Java][CI] To upload Maven and Memory Netty Buffer Patch into Apache Nightly repository#39901
Merged
kou merged 2 commits intoapache:mainfrom Feb 6, 2024
Merged
Conversation
|
|
Member
|
@github-actions crossbow submit java-jars |
|
Revision: 5530587 Submitted crossbow builds: ursacomputing/crossbow @ actions-368808e50b
|
Member
|
The same error happens on the nightly java-jars where there seems to be some |
Contributor
Author
|
@github-actions crossbow submit java-jars |
|
Member
|
@github-actions crossbow submit java-jars |
|
Revision: 7b3c329 Submitted crossbow builds: ursacomputing/crossbow @ actions-5ebbc05652
|
Member
|
@davisusanibar Could you check uploaded artifact list at https://github.com/ursacomputing/crossbow/releases/tag/actions-5ebbc05652-github-java-jars ? |
Contributor
Author
The changes allow downloading the GH assets and passing the java-jars validation in archery: It will be necessary to run https://github.com/apache/arrow/actions/workflows/java_nightly.yml after the PR is merged to verify if these new GH assets will be uploaded to https://nightlies.apache.org/arrow/java/org/apache/arrow/ {arrow-maven-plugins, arrow-memory-netty-buffer-patch, module-info-compiler-maven-plugin} |
Member
|
OK. Could you run |
Contributor
Author
Oh, I see... It's something I didn't know I could run locally, can you please let me know what steps need to be taken (do I have to run this inside the arrow repository or fork crossbow as well...)? |
Member
|
Could you read https://arrow.apache.org/docs/developers/continuous_integration/crossbow.html for the basic instruction? You need to use https://github.com/ursacomputing/crossbow/ for a Crossbow repository because https://github.com/ursacomputing/crossbow/releases/tag/actions-5ebbc05652-github-java-jars is in the repository. I think that we can use If there are some out-of-date parts in the documentation, could you update it as a separated task based on an experience in this PR? I can help you here. |
Member
|
In general, you will run |
Contributor
Author
|
1.) Upload Task: https://github.com/ursacomputing/crossbow/actions/runs/7777032405/job/21205283534 2.) Download Test on local project: https://github.com/davisusanibar/poc-arrow-windows-dll/actions/runs/7784764642/job/21225925978 |
Contributor
Author
We have uploaded all the libraries correctly to Github Assets, but the download process applies a filter Upload: Java-jar filters are not considered or applied Verify: Apply filter java-jars Download: Apply filter java-jars |
Member
|
We couldn't download all expected artifacts, right? Could you share the output of "Verify: Apply filter java-jars"? |
Contributor
Author
All is working as expected with these PR changes. Log of Verify: Apply filter java-jars: |
Contributor
Author
|
You could see download validation at: https://github.com/davisusanibar/poc-arrow-windows-dll/actions/runs/7784764642/job/21225925978 |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 0993b36. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…tch into Apache Nightly repository (apache#39901) ### Rationale for this change To upload Maven and Memory Netty Buffer Patch into Apache Nightly repository ### What changes are included in this PR? Upload Maven and Memory Netty Buffer Patch into Apache Nightly repository ### Are these changes tested? Needed to run https://github.com/apache/arrow/actions/workflows/java_nightly.yml ### Are there any user-facing changes? No * Closes: apache#39900 Authored-by: david dali susanibar arce <davi.sarces@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
To upload Maven and Memory Netty Buffer Patch into Apache Nightly repository
What changes are included in this PR?
Upload Maven and Memory Netty Buffer Patch into Apache Nightly repository
Are these changes tested?
Needed to run https://github.com/apache/arrow/actions/workflows/java_nightly.yml
Are there any user-facing changes?
No