GH-39845: [C++][Parquet] Minor: avoid creating a new Reader object in Decoder::SetData#39847
Merged
mapleFU merged 1 commit intoapache:mainfrom Feb 1, 2024
Merged
GH-39845: [C++][Parquet] Minor: avoid creating a new Reader object in Decoder::SetData#39847mapleFU merged 1 commit intoapache:mainfrom
mapleFU merged 1 commit intoapache:mainfrom
Conversation
|
|
wgtmac
approved these changes
Jan 30, 2024
Member
Author
|
Also cc @pitrou |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2721134. There were 8 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…ect in Decoder::SetData (apache#39847) ### Rationale for this change avoid creating a new Reader object in Decoder::SetData ### What changes are included in this PR? avoid creating a new Reader object in Decoder::SetData ### Are these changes tested? Already ### Are there any user-facing changes? no * Closes: apache#39845 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
avoid creating a new Reader object in Decoder::SetData
What changes are included in this PR?
avoid creating a new Reader object in Decoder::SetData
Are these changes tested?
Already
Are there any user-facing changes?
no